Selenium: Fix unexpected fails of "CreateWorkspaceTest", "AddWorkspaceToOrganizationTest", "ShareWorkspaceTest" selenium tests#9873
Merged
Ohrimenko1988 merged 2 commits intomasterfrom May 30, 2018
Conversation
Ohrimenko1988
added
kind/bug
SkorikSergey
approved these changes
May 30, 2018
dmytro-ndp
reviewed
May 30, 2018
| newWorkspace.typeWorkspaceName(MIN_VALID_WORKSPACE_NAME); | ||
|
|
||
| assertTrue(newWorkspace.isCreateWorkspaceButtonEnabled()); | ||
| newWorkspace.waitCreateWorkspaceButtonEnabled(); |
Contributor
There was a problem hiding this comment.
let's not to divide type and wait commands of the same step by empty row to make it more readable
dmytro-ndp
approved these changes
May 30, 2018
benoitf
removed
the
status/code-review
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
…eToOrganizationTest", "ShareWorkspaceTest" selenium tests (eclipse-che#9873)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix unexpected fails of "CreateWorkspaceTest", "AddWorkspaceToOrganizationTest", "ShareWorkspaceTest" selenium tests
What issues does this PR fix or reference?
Issue: #9860
Release Notes
Docs PR