Selenium: cover Clangd LS functionality by selenium test#9875
Selenium: cover Clangd LS functionality by selenium test#9875SkorikSergey merged 15 commits intomasterfrom
Conversation
SkorikSergey
added
status/code-review
|
ci-test |
|
|
||
| @Test(priority = 1) | ||
| public void checkFindDefinitionFeature() throws Exception { | ||
| prepareFile(ISEVEN_H, ISEVEN_H_CONTENT); |
There was a problem hiding this comment.
It's hard to understand what we are updating file for.
IMHO it's better to name text chunks meaningfully to express what we are changing and which operation it is aimed to test.
|
|
||
| /** @author Skoryk Serhii */ | ||
| @Test(groups = {TestGroup.DOCKER}) | ||
| public class ClangdFileEditingTest { |
There was a problem hiding this comment.
Clangd - is an open source implementation of the Language Server Protocol that leverages Clang. We are not editing it in the test. Actually, we are testing Clang file editing here.
|
|
||
| // check error marker message | ||
| editor.goToCursorPositionVisible(5, 1); | ||
| editor.waitMarkerInvisibility(ERROR, 5); |
There was a problem hiding this comment.
It would look clearer if you divide separate steps by empty rows.
| + " std::cout << \"Hello World!\" << std::endl;\n" | ||
| + " return 0;\n" | ||
| + "}"; | ||
| private static final String ISEVEN_H_CONTENT = |
There was a problem hiding this comment.
Please, add empty rows between the constants to improve readability.
| import org.testng.annotations.Test; | ||
|
|
||
| /** @author Skoryk Serhii */ | ||
| @Test(groups = {TestGroup.DOCKER}) |
There was a problem hiding this comment.
It have to be run on the both infrastructures: docker and OCP, IMHO.
|
ci-test build report: |
benoitf
removed
the
status/code-review
4 participants
What does this PR do?
This PR creates ClangdFileEditingTest selenium test which cover the Clangd language server using use cases from Language servers test plan - https://github.com/eclipse/che/wiki/Test-plan-for-checking-Language-servers.
What issues does this PR fix or reference?
#9811