Does not claim recovery is supported on docker infra#9887
Merged
mshaposhnik merged 3 commits intomasterfrom May 31, 2018
Merged
Does not claim recovery is supported on docker infra#9887mshaposhnik merged 3 commits intomasterfrom
mshaposhnik merged 3 commits intomasterfrom
Conversation
mshaposhnik
requested review from
skabashnyuk and
sleshchenko
and removed request for
garagatyi
sleshchenko
approved these changes
May 31, 2018
Member
sleshchenko
left a comment
sleshchenko
left a comment
There was a problem hiding this comment.
LGTM. Please take a look my advice
|
|
||
| @Override | ||
| public Set<RuntimeIdentity> getIdentities() throws InfrastructureException { | ||
| return containers.findIdentities(); |
Member
There was a problem hiding this comment.
I think it would be better to comment old line and add a link to issue why docker recovery is disabled #5814.
skabashnyuk
approved these changes
May 31, 2018
This was referenced May 31, 2018
gorkem
reviewed
May 31, 2018
| // Due to https://github.com/eclipse/che/issues/5814, recovering is not fully possible | ||
| // so infrastructure should not claim support of it. | ||
| // return containers.findIdentities(); | ||
| throw new UnsupportedOperationException("Runtimes tracking currently does not supported."); |
Contributor
There was a problem hiding this comment.
"Runtimes tracking currently does not supported." should be "Runtimes tracking is not supported."
benoitf
added
the
kind/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make Docker infra does not claim recovery is supported;
Fix in WS termination to allow execute termination after unsuccessful suspending;
What issues does this PR fix or reference?
#9885
Release Notes
N/A (bug)
Docs PR
N/A (bug)