Switch editors in read only mode when ws agent has stopped#9912
Merged
RomanNikitenko merged 2 commits intomasterfrom Jun 7, 2018
Merged
Switch editors in read only mode when ws agent has stopped#9912RomanNikitenko merged 2 commits intomasterfrom
RomanNikitenko merged 2 commits intomasterfrom
Conversation
RomanNikitenko
added
kind/enhancement
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Member
Author
|
ci-test |
|
ci-test build report: |
gorkem
reviewed
Jun 2, 2018
Contributor
gorkem
left a comment
gorkem
left a comment
There was a problem hiding this comment.
suggestion for the message
| messages.startingOperation=Starting {0} | ||
| messages.machine.not.found=Machine {0} not found | ||
| message.projectCreated=Project {0} created | ||
| message.switch.editors.in.readOnly.mode=Workspace agent is not running, opened editors are in read only mode |
Contributor
There was a problem hiding this comment.
Workspace agent is not running, open editors are switched to read-only mode
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Member
Author
|
ci-test |
|
ci-test build report: |
vparfonov
approved these changes
Jun 4, 2018
33 tasks
Contributor
|
Usecase is scheduled to covering by selenium test |
musienko-maxim
approved these changes
Jun 6, 2018
Contributor
|
In the functionality which is covered by selenium tests - new regression was not found |
RomanNikitenko
removed
the
status/code-review
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
…he#9912) * CHE-9620. Switch editors in read only mode when ws agent has stopped Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Switch editors in read only mode when ws agent has stopped
What issues does this PR fix or reference?
#9620
Signed-off-by: Roman Nikitenko rnikiten@redhat.com