Implement selenium test for covering LS server for TypeScript language by musienko-maxim · Pull Request #9969 · eclipse-che/che

musienko-maxim · 2018-06-08T09:07:19Z

What does this PR do?

This PR implements simple scenario: create a workspace with enabled TypeScript LS installer, open simple TypeScript project, check initialization TypeScript LS by UI, checks code validation, autocompletion, go to definition features.

What issues does this PR fix or reference?

#9918

dmytro-ndp · 2018-06-08T09:59:52Z

selenium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/CodenvyEditor.java

  }

+  /**
+   * Waits marker with specified {@code markerLocator} on the defined {@code position} and move


position could confuse a little so as it's about the line number, not just about specific position in line.

dmytro-ndp · 2018-06-08T10:05:33Z

...lenium-test/src/test/java/org/eclipse/che/selenium/languageserver/TypeScriptEditingTest.java

+  }
+
+  private void checkCodeValidation() {
+    final int expectedValueOfErrorMarkers = 9;


from the readability point it's better to divide verification by given/when/then sections.

Maybe "expectedCountOfErrorMarkers" better?

dmytro-ndp · 2018-06-08T10:05:54Z

...lenium-test/src/test/java/org/eclipse/che/selenium/languageserver/TypeScriptEditingTest.java

+  }
+
+  private void checkCodeAssistant() {
+    String textFromWholeCodeAssistantScope =


from the readability point it's better to divide verification by given/when/then sections

I have not quite understood what do you mean?
use something like that:

// when projectExplorer.openItemByPath(PATH_TO_PROGRAM); editor.setInactiveBreakpoint(22); editor.closeAllTabs(); commandsPalette.openCommandPalette(); commandsPalette.startCommandByDoubleClick(MAKE_AND_DEBUG_COMMAND_NAME); consoles.waitExpectedTextIntoConsole("Listening on port 8001"); menu.runCommandByXpath( TestMenuCommandsConstants.Run.RUN_MENU, TestMenuCommandsConstants.Run.DEBUG, getXpathForDebugConfigurationMenuItem()); notifications.waitExpectedMessageOnProgressPanelAndClosed( String.format("Remote debugger connected\nConnected to: localhost:%s.", DEBUG_PORT)); // then editor.waitTabFileWithSavedStatus("hello.cc"); debugPanel.waitDebugHighlightedText(" return \"Hello World, \" + name + \"!\";"); debugPanel.waitTextInVariablesPanel("name ="); debugPanel.waitTextInVariablesPanel("\"man\"");

dmytro-ndp · 2018-06-08T10:08:24Z

...lenium-test/src/test/java/org/eclipse/che/selenium/languageserver/TypeScriptEditingTest.java

+    editor.waitTextIntoAutocompleteContainer(textFromWholeCodeAssistantScope);
+    editor.closeAutocomplete();
+    editor.typeTextIntoEditor(ENTER.toString());
+    editor.typeTextIntoEditor("greeter.");


it's hard to understand test case here
Could you, please, name string "greeter." somehow to make its propose an obvious?

In the test based on simple Greeter example like:
Greeter example

class Greeter { greeting: string; constructor(message: string) { this.greeting = message; } greet() { return "Hello, " + this.greeting; } testPrint(): void { const printVar = new Print(); printVar.print("test print"); } } let greeter = new Greeter("world");

and i cannot see difficult parts for understanding

To protect the test from occasional breaking down we need to have clear vision why it cann't be "hello", "buy" and any other string :-)

Ok, your proposal?

Ohrimenko1988 · 2018-06-08T10:08:45Z

...lenium-test/src/test/java/org/eclipse/che/selenium/languageserver/TypeScriptEditingTest.java

+import static org.eclipse.che.selenium.core.workspace.WorkspaceTemplate.ECLIPSE_NODEJS;
+import static org.eclipse.che.selenium.pageobject.CodenvyEditor.MarkerLocator.ERROR;
+import static org.eclipse.che.selenium.pageobject.CodenvyEditor.MarkerLocator.ERROR_OVERVIEW;
+import static org.openqa.selenium.Keys.*;


This is a kind of anti-pattern, please use direct static import

dmytro-ndp · 2018-06-08T10:09:05Z

...lenium-test/src/test/java/org/eclipse/che/selenium/languageserver/TypeScriptEditingTest.java

+            "The expected value of errors marker should be %d but actual %d",
+            expectedValueOfErrorMarkers, actualValueErrorMarkers));
+    editor.waitMarkerInPositionAndMoveCursor(ERROR_OVERVIEW, 13);
+    editor.waitTextInToolTipPopup("Cannot find name 'c'");


it's hard to understand test case here
Could you, please, name string "Cannot find name 'c'" somehow to make its propose an obvious?

This message is returned by Language Server and we can not control this one in this case

I didn't mean control - I meant name this string somehow to make its propose clear, and we can do it in our test.

dmytro-ndp · 2018-06-08T10:10:29Z

...lenium-test/src/test/java/org/eclipse/che/selenium/languageserver/TypeScriptEditingTest.java

+  }
+
+  private void checkGoToDefinition() {
+    editor.goToPosition(24, 20);


Could you, please, comment in the code which definition we a going to here?

dmytro-ndp · 2018-06-08T13:01:21Z

selenium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/CodenvyEditor.java

+   * @param markerLocator marker's type, defined in {@link MarkerLocator}
+   * @param position line's number, where marker is expected
+   */
+  public void waitMarkerInPositionAndMoveCursor(MarkerLocator markerLocator, int position) {


moveCursorToLineWithMarker(MarkerLocator markerLocator, int line) would explain the propose of method better, IMHO

dmytro-ndp · 2018-06-08T13:02:43Z

...lenium-test/src/test/java/org/eclipse/che/selenium/languageserver/TypeScriptEditingTest.java

+  }
+
+  private void checkCodeAssistant() {
+


redundant empty line

dmytro-ndp · 2018-06-08T13:03:36Z

...lenium-test/src/test/java/org/eclipse/che/selenium/languageserver/TypeScriptEditingTest.java

+
+    String nameOfGreeterClassRef = "greeter.";
+
+    editor.goToPosition(28, 36);


could you, please divide separate steps by empty lines to improve readability?

…t steps

musienko-maxim · 2018-06-08T14:16:11Z

ci-build

codenvy-ci · 2018-06-08T14:57:42Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4551/

musienko-maxim · 2018-06-08T17:03:55Z

ci-test

codenvy-ci · 2018-06-08T22:13:51Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9969
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

eclipse-che#9969) * finish the test and adapt files from resources for the test

musienko-maxim added 2 commits June 5, 2018 17:20

create sceleton for the test

0dedab5

finish the test and adapt files from resources for the test

4f5f64d

musienko-maxim requested a review from vparfonov as a code owner June 8, 2018 09:07

benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Jun 8, 2018

enable typescript LS for openshift infrastructure, apply formatting

000ab2b

musienko-maxim requested review from Ohrimenko1988, artaleks9 and dmytro-ndp June 8, 2018 09:37

Add empty lines to resources files

7a27147

artaleks9 approved these changes Jun 8, 2018

View reviewed changes

dmytro-ndp reviewed Jun 8, 2018

View reviewed changes

Ohrimenko1988 reviewed Jun 8, 2018

View reviewed changes

dmytro-ndp reviewed Jun 8, 2018

View reviewed changes

Ohrimenko1988 approved these changes Jun 8, 2018

View reviewed changes

musienko-maxim added 3 commits June 8, 2018 13:20

apply proposal to PR

d035351

apply formatting for better readability

df916a9

set the name for unclear literals

b5824b3

dmytro-ndp reviewed Jun 8, 2018

View reviewed changes

musienko-maxim added 3 commits June 8, 2018 16:29

rename method for better readability, add separation between differen…

fc71e42

…t steps

rename method for better readability, add separation between differen…

0657f25

…t steps

add propals to PR for better readability

e059c31

dmytro-ndp approved these changes Jun 8, 2018

View reviewed changes

musienko-maxim merged commit 60f123d into master Jun 10, 2018

musienko-maxim deleted the CHE-9918 branch June 10, 2018 20:53

benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 10, 2018

benoitf added this to the 6.7.0 milestone Jun 10, 2018

hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018

Implement selenium test for covering LS server for TypeScript language (

8ef4b04

eclipse-che#9969) * finish the test and adapt files from resources for the test


		String nameOfGreeterClassRef = "greeter.";

		editor.goToPosition(28, 36);

Conversation

musienko-maxim commented Jun 8, 2018

What does this PR do?

What issues does this PR fix or reference?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Jun 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Jun 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

musienko-maxim Jun 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

musienko-maxim Jun 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

musienko-maxim Jun 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Jun 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

musienko-maxim commented Jun 8, 2018

Uh oh!

codenvy-ci commented Jun 8, 2018

Uh oh!

musienko-maxim commented Jun 8, 2018

Uh oh!

codenvy-ci commented Jun 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dmytro-ndp Jun 8, 2018 •

edited

Loading

dmytro-ndp Jun 8, 2018 •

edited

Loading

musienko-maxim Jun 8, 2018 •

edited

Loading

musienko-maxim Jun 8, 2018 •

edited

Loading

musienko-maxim Jun 8, 2018 •

edited

Loading

dmytro-ndp Jun 8, 2018 •

edited

Loading