Add support of Workspace Next to Openshift infrastructure #9981
Merged
garagatyi merged 2 commits intoeclipse-che:masterfrom Jun 11, 2018
Merged
Add support of Workspace Next to Openshift infrastructure #9981garagatyi merged 2 commits intoeclipse-che:masterfrom
garagatyi merged 2 commits intoeclipse-che:masterfrom
Conversation
added 2 commits
June 8, 2018 15:26
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
ghost
approved these changes
Jun 8, 2018
benoitf
added
kind/enhancement
sleshchenko
approved these changes
Jun 11, 2018
Member
sleshchenko
left a comment
sleshchenko
left a comment
There was a problem hiding this comment.
LGTM.
Just proposal to add an option to deploy che script to deploy and configure feature-api.
| name: openshift-identity-provider | ||
| optional: true | ||
| - name: CHE_WORKSPACE_FEATURE_API | ||
| value: "http://feature-api-service:3000" |
Member
There was a problem hiding this comment.
Does it mean that WS next functionality will be enabled even when feature API is not deployed?
Author
There was a problem hiding this comment.
Yes, it will be configured but it won't work unless someone adds features property in his workspace. So, I think it is OK to set it by default to simplify deployment in case Workspace Next functionality is needed.
benoitf
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support of Workspace Next to Openshift recipe, infrastructure.
Adds a template to deploy Feature API to Openshift.
What issues does this PR fix or reference?
Release Notes
Docs PR