Skip to content

Issue #2560 - Review of PathResource exception handling#2561

Merged
joakime merged 7 commits intojetty-9.4.xfrom
jetty-9.4.x-issue-2560-pathresource-exceptions
May 31, 2018
Merged

Issue #2560 - Review of PathResource exception handling#2561
joakime merged 7 commits intojetty-9.4.xfrom
jetty-9.4.x-issue-2560-pathresource-exceptions

Conversation

@joakime
Copy link
Contributor

@joakime joakime commented May 22, 2018

Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime requested a review from gregw May 22, 2018 15:31
@joakime joakime added this to the 9.4.x milestone May 31, 2018
@gregw
Copy link
Contributor

gregw commented May 31, 2018

#2560

Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than quibble

}
catch(InvalidPathException e)
{
throw (InvalidPathException) new InvalidPathException(childPath, e.getReason()).initCause(e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the coerce?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initCause() returns Throwable

joakime added 3 commits May 31, 2018 10:15
…ontentFactory

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
…ub.com:eclipse/jetty.project into jetty-9.4.x-issue-2560-pathresource-exceptions
@joakime joakime merged commit a51920d into jetty-9.4.x May 31, 2018
@joakime joakime deleted the jetty-9.4.x-issue-2560-pathresource-exceptions branch May 31, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants