Refactor cluster dut aux#191
Merged
sebastianpfischer merged 6 commits intoJan 20, 2023
Merged
Conversation
TedRio
approved these changes
Nov 7, 2022
sebastianpfischer
requested review from
BKaDamien,
Pog3k and
sebastianpfischer
sebastianpfischer
requested changes
Nov 8, 2022
Contributor
sebastianpfischer
left a comment
sebastianpfischer
left a comment
There was a problem hiding this comment.
How do we ensure that we do not break anything bad? Do we merge that and do the changes in our internal project to validate them?
I find it all risky somehow ^^
BKaDamien
suggested changes
Nov 9, 2022
Pog3k
reviewed
Nov 14, 2022
Pog3k
reviewed
Nov 14, 2022
sebclrsn
requested changes
Nov 15, 2022
Pog3k
approved these changes
Nov 23, 2022
Contributor
|
@yannpoupon what is the status? |
Contributor
Author
|
All suggestions have been applied, a PR for our plugins has been created, where all raw have been removed from the function |
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 95.37% 95.43% +0.06%
==========================================
Files 72 72
Lines 5551 5542 -9
==========================================
- Hits 5294 5289 -5
+ Misses 257 253 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
This shall me be merged before 0.21.0 |
sebclrsn
approved these changes
Jan 12, 2023
Contributor
|
Should we review or still wait? |
Contributor
Author
|
It should be reviewed to be merged to do the new release. |
yannpoupon
requested review from
BKaDamien and
sebastianpfischer
and removed request for
BKaDamien and
sebastianpfischer
sebastianpfischer
requested changes
Jan 20, 2023
sebastianpfischer
approved these changes
Jan 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable the message serialization/deserialization in the aux using it (DuT-auxiliary)
remove in the cc the parameter "raw" because "msg" only contain raw messages. Additional missing parameters are added as kwargs