Skip to content

fix: enable internal file logging when junit option is provided#385

Merged
sebclrsn merged 3 commits into
eclipse-kiso-testing:masterfrom
sebclrsn:bugfix/internal-file-logging-whit-junit-reporting
Oct 9, 2023
Merged

fix: enable internal file logging when junit option is provided#385
sebclrsn merged 3 commits into
eclipse-kiso-testing:masterfrom
sebclrsn:bugfix/internal-file-logging-whit-junit-reporting

Conversation

@sebclrsn
Copy link
Copy Markdown
Contributor

@sebclrsn sebclrsn commented Oct 5, 2023

When running pykiso without verbose but with the junit option provided, the internal logs were no longer displayed in the provided log file

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 5, 2023

Codecov Report

Merging #385 (a3b18cb) into master (5f203e5) will decrease coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
- Coverage   97.09%   97.09%   -0.01%     
==========================================
  Files          85       85              
  Lines        6824     6816       -8     
==========================================
- Hits         6626     6618       -8     
  Misses        198      198              
Files Coverage Δ
src/pykiso/logging_initializer.py 100.00% <100.00%> (ø)
src/pykiso/test_coordinator/test_case.py 95.50% <ø> (-0.24%) ⬇️
src/pykiso/test_result/xml_result.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@sebastianpfischer sebastianpfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@sebclrsn sebclrsn merged commit 3abca3d into eclipse-kiso-testing:master Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants