Binary dynamic properties should generate properties after an update#159
Merged
rgrunber merged 1 commit intoeclipse-lsp4mp:masterfrom Aug 4, 2021
Merged
Conversation
Contributor
Author
|
I need to write more tests. |
angelozerr
force-pushed
the
dynamic-props-update
branch
from
75886b9 to
2a47a9a
Compare
Signed-off-by: azerr <azerr@redhat.com>
Contributor
|
I am planning on reviewing this |
datho7561
approved these changes
Aug 4, 2021
Contributor
|
The tests don't fail on my computer |
Contributor
Author
I restarted the job, test is working. |
rgrunber
approved these changes
Aug 4, 2021
Contributor
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
Change looks good to me and seems to be working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binary dynamic properties should generate properties after an update
Signed-off-by: azerr azerr@redhat.com