Property expression definition#19
Merged
angelozerr merged 1 commit intoeclipse-lsp4mp:masterfrom Sep 3, 2020
Merged
Conversation
|
In this case, can we have the goto definition go to |
datho7561
force-pushed
the
333-property-expression-definition
branch
from
56105a1 to
8fc2140
Compare
datho7561
commented
Jul 27, 2020
datho7561
force-pushed
the
333-property-expression-definition
branch
2 times, most recently
from
3281eb6 to
56bea85
Compare
datho7561
changed the title
datho7561
force-pushed
the
333-property-expression-definition
branch
from
56bea85 to
0037b81
Compare
Contributor
For this use case we should have 3 definitions I think (city, %prod.city and %dev.city), no? |
Contributor
Author
I think this could be helpful, depending on how the client supports multiple definitions being sent from the server. |
Contributor
Author
|
This is the behaviour in vscode if the server returns multiple definitions:
I think being able to direct the user to the different definitions is helpful. |
datho7561
force-pushed
the
333-property-expression-definition
branch
from
0037b81 to
6387a6c
Compare
angelozerr
reviewed
Sep 3, 2020
angelozerr
reviewed
Sep 3, 2020
You can now trigger Go To Definition inside ${...},
and it will navigate to the location where the property
value is assigned in the properties file.
Closes redhat-developer/quarkus-ls#333.
Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
333-property-expression-definition
branch
from
6387a6c to
cc50cca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can now trigger Go To Definition inside ${...}, and it will navigate to the location where the property value is assigned in the properties file.
Closes redhat-developer/quarkus-ls#333.
Signed-off-by: David Thompson davthomp@redhat.com