Fixed bug with missing definition hover for multiple annotation members

[AlexXuChen]

Fixed bug with missing definition hover for multiple annotation members

References #214 (comment)

Signed-off-by: Alexander Chen alchen@redhat.com

[angelozerr]

Could you write a test please.

[AlexXuChen]

Could you write a test please.

There are existing tests for this feature (e.g. hover), the definition related tests are part of quarkus-ls: redhat-developer/quarkus-ls/pull/458

[angelozerr]

As this PR belongs to LSP4MP we should have tests (even if we have some tests on Quarkus LS side). In other words we should have tests:

• for hover with ConfigProperty name with one member
  • (ex : ConfigProperty(name = "greeting.mess|age"))
  • and two members (check existing tests). For two members I will write a test with ConfigProperty(defaultValue = "hello", name = "greeting.mess|age")
• for definition with ConfigProperty like hover.

[AlexXuChen]

As this PR belongs to LSP4MP we should have tests (even if we have some tests on Quarkus LS side). In other words we should have tests:

As I mentioned, there are existing tests for hover: https://github.com/eclipse/lsp4mp/blob/master/microprofile.jdt/org.eclipse.lsp4mp.jdt.test/src/main/java/org/eclipse/lsp4mp/jdt/core/config/java/MicroProfileConfigJavaHoverTest.java, which already handle the multiple member cases, and definition: https://github.com/eclipse/lsp4mp/blob/master/microprofile.jdt/org.eclipse.lsp4mp.jdt.test/src/main/java/org/eclipse/lsp4mp/jdt/core/config/java/MicroProfileConfigJavaDefinitionTest.java. For this pr, since it is on the lsp4mp side, only name is supported with ConfigProperty definition hover, and this test case is already handled: https://github.com/eclipse/lsp4mp/blob/ec5f1ab23b1d3f08f2bd6b60f37bea15a3069d6d/microprofile.jdt/org.eclipse.lsp4mp.jdt.test/src/main/java/org/eclipse/lsp4mp/jdt/core/config/java/MicroProfileConfigJavaDefinitionTest.java#L90

[angelozerr]

As I mentioned, there are existing tests

Oh my bad, you are totaly right, sorry I see too quickly your PR and comments.

[angelozerr]

Good job @AlexXuChen !