Escape special characters within LSP snippets#29
Merged
fbricon merged 1 commit intoeclipse-lsp4mp:masterfrom Aug 28, 2020
xorye:351escape_snippet
Merged
Escape special characters within LSP snippets#29fbricon merged 1 commit intoeclipse-lsp4mp:masterfrom xorye:351escape_snippet
fbricon merged 1 commit intoeclipse-lsp4mp:masterfrom
xorye:351escape_snippet
Conversation
Signed-off-by: David Kwon <dakwon@redhat.com>
datho7561
approved these changes
Jul 27, 2020
rzgry
approved these changes
Jul 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/quarkus-ls#351
The issue was happening because the
$and}characters were not being escaped. This PR escapes special snippet characters for properties' default values.To test that this PR is working properly, try completion with the
quarkus.container-image.groupproperty as explained in the original issue, or try completion with a config property containing${and}:After properties completion, the default value should be completely highlighted:
Signed-off-by: David Kwon dakwon@redhat.com