Fix inlay hint + definition when project returns empty properties.#311
Merged
datho7561 merged 1 commit intoeclipse-lsp4mp:masterfrom Nov 9, 2022
Merged
Conversation
angelozerr
force-pushed
the
empty-properties
branch
2 times, most recently
from
accd561 to
1748693
Compare
Contributor
Author
|
I have written test for inlay hint. I need to write test for definition now. |
angelozerr
force-pushed
the
empty-properties
branch
2 times, most recently
from
7e3a76c to
a19c897
Compare
Signed-off-by: azerr <azerr@redhat.com>
Contributor
Author
|
It should be good now. |
datho7561
approved these changes
Nov 9, 2022
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good! I can't think of a way to test this manually, since even in non-microprofile projects the config_ordinal property is present (this is a bug, I think it should depend on microprofile-config being present).
Contributor
|
See #312 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix inlay hint + definition when project returns empty properties.
Signed-off-by: azerr azerr@redhat.com