Skip to content

Enable SSE/SSE2 on OMR X86-32 #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0dvictor wants to merge 1 commit into from
Closed

Enable SSE/SSE2 on OMR X86-32 #2822

0dvictor wants to merge 1 commit into from

Conversation

@0dvictor
Copy link
Contributor

@0dvictor 0dvictor commented Aug 2, 2018 •
edited
Loading

All known downstream projects uses SSE/SSE2 for floating point operations;
however OMR itself still kept X87 as default on X86-32.
This commit turns SSE/SSE2 on as default, allowing OMR's tests exercising SSE/SSE2 route.
X87 support is deprecated, and will be removed.

Closes #2429

Signed-off-by: Victor Ding dvictor@ca.ibm.com

@0dvictor 0dvictor force-pushed the sse branch 3 times, most recently from 52716af to 388c50b Compare August 2, 2018 04:01
@0dvictor 0dvictor force-pushed the sse branch 2 times, most recently from a2a165c to 17bd256 Compare August 2, 2018 19:00
@vijaysun-omr vijaysun-omr self-assigned this Aug 7, 2018
@vijaysun-omr
Copy link
Contributor

vijaysun-omr commented Aug 7, 2018

I think @0xdaryl and @andrewcraik should review this.

@0dvictor 0dvictor force-pushed the sse branch 2 times, most recently from ae46c6f to 8131749 Compare August 14, 2018 18:19
@0dvictor
Copy link
Contributor Author

0dvictor commented Aug 14, 2018

I have separated changes that does not strictly belong to enabling SSE/SSE2 into different pull requests: #2852 and #2853.

Note that now this pull request requires #2852.

@0xdaryl
Copy link
Contributor

0xdaryl commented Aug 14, 2018

You should mark this PR as a WIP until #2852 is merged then.

@0dvictor 0dvictor changed the title Enable SSE/SSE2 on OMR X86-32 WIP: Enable SSE/SSE2 on OMR X86-32 Aug 14, 2018
@0dvictor
Copy link
Contributor Author

0dvictor commented Aug 14, 2018 •
edited
Loading

You should mark this PR as a WIP until #2852 is merged then.

Good point, done.

@0dvictor 0dvictor mentioned this pull request Aug 14, 2018
Closed
@0dvictor 0dvictor changed the title WIP: Enable SSE/SSE2 on OMR X86-32 Enable SSE/SSE2 on OMR X86-32 Aug 15, 2018
@0dvictor
Copy link
Contributor Author

0dvictor commented Aug 15, 2018

#2852 has been merged, and this pull request is ready to be merged.

@0dvictor 0dvictor force-pushed the sse branch 4 times, most recently from 7ab4e7d to 2646d88 Compare August 21, 2018 19:19
@0dvictor 0dvictor mentioned this pull request Aug 24, 2018
Merged
@mstoodle mstoodle requested a review from 0xdaryl August 27, 2018 14:55
@mstoodle
Copy link
Contributor

mstoodle commented Aug 27, 2018

I "formally" requested a review from @0xdaryl and will use this comment to ping @andrewcraik for reviews. Both are currently away so this one will need to sit for a couple of weeks, I'm afraid.

@0dvictor 0dvictor mentioned this pull request Aug 27, 2018
Merged
@andrewcraik
Copy link
Contributor

andrewcraik commented Sep 13, 2018

looks fine to me - it has been quite a while since there was an x86 processor without SSE/SSE2...

@vijaysun-omr
Copy link
Contributor

vijaysun-omr commented Sep 13, 2018

Awaiting your review @0xdaryl please.

@0dvictor 0dvictor mentioned this pull request Nov 8, 2018
Open
@0dvictor
Copy link
Contributor Author

0dvictor commented Nov 8, 2018

Conflicts have been resolved.

@andrewcraik
Copy link
Contributor

andrewcraik commented Nov 9, 2018

@0xdaryl ping now that the conflicts are resolved

@0xdaryl
Copy link
Contributor

0xdaryl commented Nov 12, 2018

I'm going to be working out a staged plan for SSE removal from OMR this week as part of #946. There are obviously some OpenJ9 dependencies with this work. I want to make sure merging this PR now follows that plan as I don't want us to be taking random potshots at removing it. Hope that's ok.

@vijaysun-omr
Copy link
Contributor

vijaysun-omr commented Nov 12, 2018

Sure that sounds good @0xdaryl
We just need guidance for this PR to be concluded or re-worked and hopefully that is possible this week.

@samolisov samolisov mentioned this pull request Nov 15, 2018
Merged
@0dvictor 0dvictor requested a review from mstoodle as a code owner November 23, 2018 20:29
hzongaro pushed a commit to hzongaro/omr that referenced this pull request Nov 26, 2018
@samolisov @hzongaro
Remove TR_X86FPStackIterator (X87 FP) class
de3700f 
As it is discussed in eclipse-omr#2822, X87 support is deprecated, and will be
removed. This fact lets us the opportunity to remove
'TR_X86FPStackIterator' from the codebase as the first step to
consolidate implementations of RegisterIterator.

Issue: eclipse-omr#2645
Signed-off-by: Pavel Samolysov <samolisov@gmail.com>
@vijaysun-omr
Copy link
Contributor

vijaysun-omr commented Nov 29, 2018

@0xdaryl this is waiting for your opinion.

@Leonardo2718
Copy link
Contributor

Leonardo2718 commented Dec 19, 2018

@0xdaryl ping

@vijaysun-omr
Copy link
Contributor

vijaysun-omr commented Feb 19, 2019

@0xdaryl ping

@0dvictor 0dvictor force-pushed the sse branch 2 times, most recently from a4de184 to 19c544c Compare March 12, 2019 22:20
@0dvictor
Copy link
Contributor Author

0dvictor commented Mar 21, 2019

The AppVeyor failure is due to infra.

@Leonardo2718
Copy link
Contributor

Leonardo2718 commented Mar 22, 2019

Restarted AppVeyor build.

@vijaysun-omr
Copy link
Contributor

vijaysun-omr commented Apr 5, 2019

@0xdaryl ping

@andrewcraik
Copy link
Contributor

andrewcraik commented Apr 9, 2019

@0xdaryl ping?

Enable SSE/SSE2 on OMR X86-32
71ca600 
All known downstream projects uses SSE/SSE2 for floating point operations;
however OMR itself still kept X87 as default on X86-32.
This commit turns SSE/SSE2 on as default, allowing OMR's tests exercising SSE/SSE2 route.
X87 support is deprecated, and will be removed.

Signed-off-by: Victor Ding <dvictor@ca.ibm.com>
@dchopra001 dchopra001 mentioned this pull request Jun 12, 2019
Closed
@vijaysun-omr vijaysun-omr assigned 0xdaryl and unassigned vijaysun-omr Jul 11, 2019
@0xdaryl
Copy link
Contributor

0xdaryl commented Apr 29, 2021

Subsumed by #5965.

@0xdaryl 0xdaryl closed this Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xdaryl 0xdaryl Awaiting requested review from 0xdaryl 0xdaryl is a code owner

@mstoodle mstoodle Awaiting requested review from mstoodle mstoodle is a code owner

Assignees

@0xdaryl 0xdaryl

Labels

arch:x86 comp:compiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Turn SSE/SSE2 on as default on X86-32

6 participants

@0dvictor @vijaysun-omr @0xdaryl @mstoodle @andrewcraik @Leonardo2718