Make arraytranslate return correct # of translated chars #3719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arraytranslateEncodeSIMDEvaluator helper function invoked by the arraytranslateEvaluator does not correctly add the number of residue characters succesfully translated if a saturated value is encountered in the second input vector. This commit adds an add instruction to correctly account for all the values successfuly translated. Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
dchopra001
force-pushed
the
arraytranslate_ext
branch
from
8355cf7 to
b8cfdce
Compare
fjeremic
approved these changes
Apr 9, 2019
Contributor
|
@dchopra001 I think you'll need to sign in and re-sign the ECA. |
Contributor
|
@genie-omr build zlinux,zos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arraytranslateEncodeSIMDEvaluator helper function invoked by the arraytranslateEvaluator does not correctly add the number of residue characters succesfully translated if a saturated value is encountered in the second input vector. This commit adds an add instruction to correctly account for all the values successfuly translated.
Signed-off-by: Dhruv Chopra Dhruv.C.Chopra@ibm.com