Map OMRPORT_RESOURCE_ADDRESS_SPACE to RLIMIT_MEMLIMIT for z/OS 64 bit#5886
Merged
Conversation
z/OS application using IARV64/__moservices can only allocate memory at "memory above bar" which is specified by RLIMIT_MEMLIMIT, not RLIMIT_AS. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
JasonFengJ9
requested review from
charliegracie,
rwy7 and
youngar
as code owners
joransiu
approved these changes
Apr 1, 2021
joransiu
left a comment
joransiu
left a comment
Contributor
There was a problem hiding this comment.
LGTM. We have confirmation from zOS team that RLIMIT_AS is applies only to below-the-bar storage, and RLIMIT_MEMLIMIT applies to above-the-bar.
Contributor
|
I still think that omrsysinfo_get_addressable_physical_memory() should subtract 2GB from the |
pshipton
approved these changes
Apr 7, 2021
Contributor
|
@babsingh can you pls review |
Contributor
|
Jenkins build all |
babsingh
approved these changes
Apr 7, 2021
Contributor
|
@0xdaryl Request to merge once the PR builds succeed. |
Contributor
Author
This can be discussed further at #5881 |
0xdaryl
approved these changes
Apr 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
z/OSapplication usingIARV64/__moservicescan only allocate memory atmemory above barwhich is specified byRLIMIT_MEMLIMIT, notRLIMIT_AS.related #5881
Signed-off-by: Jason Feng fengj@ca.ibm.com