Skip to content

Enable SVM during startup #4723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpirvu merged 1 commit into from
Feb 14, 2019
Merged

Enable SVM during startup #4723

mpirvu merged 1 commit into from
Feb 14, 2019

Conversation

@dsouzai
Copy link
Contributor

@dsouzai dsouzai commented Feb 13, 2019 •
edited
Loading

Fixes #4138
Fixes #4201

Enable SVM during startup
0ef6e27 
Signed-off-by: Irwin D'Souza <dsouzai@ca.ibm.com>
@dsouzai
Copy link
Contributor Author

dsouzai commented Feb 13, 2019

jenkins test sanity all jdk8,jdk11

@dsouzai
Copy link
Contributor Author

dsouzai commented Feb 13, 2019

I verified that enabling the SVM during startup does not result in a startup regression, thanks to all of @jdmpapin 's excellent work in #3752

@dsouzai
Copy link
Contributor Author

dsouzai commented Feb 13, 2019

@mpirvu for your review.

@dsouzai dsouzai mentioned this pull request Feb 13, 2019
Closed
mpirvu
mpirvu approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu mpirvu self-assigned this Feb 13, 2019
@mpirvu
Copy link
Contributor

mpirvu commented Feb 14, 2019

There is one failure in Java11 LinuxAMD64

18:51:23         FAILED: testAnonClassCodePaths
18:51:23         java.lang.NullPointerException
18:51:23         	at java.base/java.lang.Integer.valueOf(Integer.java:1049)

Is there any chance the failure is due to SVM being enabled during startup?

@dsouzai
Copy link
Contributor Author

dsouzai commented Feb 14, 2019

No, doesn't look like it. The test was run with

JVM_OPTIONS: -Xnocompressedrefs -Xjit -Xgcpolicy:gencon -Xnocompressedrefs

so there was no AOT code.

@mpirvu mpirvu merged commit 3993c81 into eclipse-openj9:master Feb 14, 2019
@jdmpapin jdmpapin mentioned this pull request Feb 14, 2019
Closed
28 tasks
@dsouzai dsouzai deleted the enableSVM branch June 25, 2019 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpirvu mpirvu mpirvu approved these changes

Assignees

@mpirvu mpirvu

Labels

comp:jit:aot comp:jit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dsouzai @mpirvu