Don't generate checkcast when types are compatible #6192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source type and target type are store in MethodHandle object, so generate checkcast according to the compatibility between types. Signed-off-by: Liqun Liu <liqunl@ca.ibm.com>
Member
|
@liqunl Reading this it appears to be an optimization to skip AsType/ExplicitCastArguments when the types are the same or compatible. Very happy to see this! |
Contributor
|
Looks pretty good - will wait for unWIP before final review - I agree this is a good one to nail |
liqunl
changed the title
Contributor
Author
|
@andrewcraik Tested with personal build. Could you review? |
andrewcraik
approved these changes
Jun 21, 2019
Contributor
|
Jenkins test sanity xlinux,win,plinux jdk8,jdk11 |
Contributor
Author
|
@vijaysun-omr The builds failed because jenkins restarted itself, do you mind restarting the build for me? |
Member
|
Jenkins test sanity xlinux jdk8,jdk11 |
Member
|
Restarted the failed linux builds |
Contributor
Author
|
@DanHeidinga All the tests have passed, could you merge this PR? |
Member
|
Normally I'd wait for @andrewcraik as he reviewed it but I understand he's not available. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source type and target type are store in MethodHandle object, so
generate checkcast according to the compatibility between types.
#4837
Signed-off-by: Liqun Liu liqunl@ca.ibm.com