Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 525459 - TTY shell failed to get user after recent change about m… #206

Merged
merged 3 commits into from Oct 2, 2017
Merged

Bug 525459 - TTY shell failed to get user after recent change about m… #206

merged 3 commits into from Oct 2, 2017

Conversation

soulbeing
Copy link
Contributor

…ake authentication a middleware

@soulbeing soulbeing requested a review from squarti October 2, 2017 15:15
@eclipsewebmaster
Copy link

Issue tracker reference:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=525459

@soulbeing soulbeing requested a review from mrennie October 2, 2017 15:15
mrennie
mrennie approved these changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@mrennie mrennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@soulbeing soulbeing merged commit a6a79e7 into master Oct 2, 2017
@soulbeing soulbeing deleted the Bug525459 branch October 2, 2017 18:35
mrennie added a commit that referenced this pull request Oct 3, 2017
@mrennie
Revert "Bug 525459 - TTY shell failed to get user after recent change…
8d0ecb8 
… about m… (#206)"

This reverts commit a6a79e7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squarti squarti squarti approved these changes

@mrennie mrennie mrennie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@soulbeing @eclipsewebmaster @mrennie @squarti @SidneyJiang