Refactor net base for pipeline#2044
Merged
Merged
Conversation
ppatierno
reviewed
Jul 10, 2017
ppatierno
left a comment
ppatierno
left a comment
There was a problem hiding this comment.
Looking at the branch for using it with the MQTT server, it seems that the usage it's pretty simple.
Member
Author
|
can you check if there are any Netty errors ? |
|
what do you mean by Netty errors ? |
Member
Author
|
I mean review the quality of the code :-) |
Member
Author
|
and I know you know Netty :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the internal api to extend TCP client and server. Previously one had to use inheritance, this new one exposes instead a
NetSocketInternalthat allows to read/write any pipeline message and modify the channel pipeline.