examples/client: Fix access control object read#427
Closed
leandrolanzieri wants to merge 1 commit intoeclipse-wakaama:masterfrom
Closed
examples/client: Fix access control object read#427leandrolanzieri wants to merge 1 commit intoeclipse-wakaama:masterfrom
leandrolanzieri wants to merge 1 commit intoeclipse-wakaama:masterfrom
Conversation
Contributor
|
Hi, Thanks for this. For being able to merge your PR you need to sign the Eclipse CLA and sign your commits with the same email address. See: https://wiki.eclipse.org/Development_Resources/Contributing_via_Git#Eclipse_Foundation_Contributor_License_Agreement Regards, |
Signed-off-by: Leandro Lanzieri <lanzierileandro@gmail.com>
leandrolanzieri
force-pushed
the
pr/examples/client-fix_acc_ctrl_read
branch
from
5fb27bf to
775274b
Compare
Author
|
@dnav done |
Author
|
Any plans on applying this fix? |
Closed
Contributor
|
This was fixed by b1f181d. I think we can close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the Access Control object implementation of the Client example when the
prv_set_tlvfunction is called the data is encoded into the data pointer using the helping function for encoding instances. The amount of instances being encoded was hardcoded and didn't work if a different number of items were present in the access control list. This fixes this.Test procedure
Run the example before and after applying this PR with a number different to 2 in the access control list.