-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Week 2/day 3 contribution upsell #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n setup troubleshooting
Added information on setting up a valid payment method in the user's OpenAI account to avoid the out of quota error.
Update README.md
… JavaScript heavely at the end of week1 day1 notebook and tested it using openai, cnn, edwarddonner webpage
Sd enhancements
Add the completed notebook for Week 1's code exercise to the `community-contributions/week-1` folder. This notebook provides a practical example of the concepts covered in the week's materials.
…pt-summary Add Week 1 Notebook to Community Contributions
Added my_question as an input field for prompts to both the models
Adding checks for the ffprobe and ffplay as both are used too.
…ader-feature Adding contribution
…b_week2_day4 Typo. Fix from "Unknow" to "Unknown"
…-tool add discount tool - week2 -day4
week 2 solution with audio input
Hey Paul!
Thanks for making the PR and sharing your project - terrific!
It looks like it has your change in there OK, but there’s something odd going on with it saying you made 100+ commits.. I’m not sure if it’s anything to be concerned about. If you have time, please could you ask ChatGPT or Claude is there’s anything we can do to clean this up? Otherwise I’ll take more of a look when I have a minute and see what’s going on.
Thanks so much
Ed
…_____
Edward Donner
On Dec 16, 2024 at 1:08 PM +0000, pagwin ***@***.***>, wrote:
Hi Ed,
This is my first pull request so it may be wrong.
Anyway, I created an upsell option for the clothes shop exercise, hope it's ok
BTW. Loving AI ...
Cheers Paul
You can view, comment on, or merge this pull request online at:
#40
Commit Summary
• 6d2e87d Initial commit
• 3f2b254 Initial commit with weeks 1-4
• d7c4189 Now with more weeks!
• f797782 README update
• e09e2d4 Tidying up
• 07e1b22 Fixed problem with colons in filenames and added more of week 6
• 8bb0122 Included links to all Google Colabs in the README and week 3 folder
• 6352bba README updates
• bab4a3a Another minor README tweak
• f48bc31 Updated README and added week 6 day 5
• 1e2d5a0 Updated README and projects with details of APIs and costs, and common setup troubleshooting
• aa26347 Added week 7 colab links
• f5cfa00 Updated README and Week 8 coming together
• e97b749 README tweaks
• 32f95ed Fixed Google Colab link in week 3 day 4, and latest week 8 updates
• 46c4f2d Updated Week 3 day 4 link to point to right colab
• 5bad34c Update README.md
• 0d579f4 Merge pull request #1 from Fuse56/patch-1
• a4bb92e enhanced structure and comments for week 1 and added a Spanish version
• ba4c4a1 Week 8 updates
• 8aea329 Merge branch 'main' of github.com:ed-donner/llm_engineering
• ee07db4 enhanced structure and comments for week 1 and added a Spanish version
• 1e67893 More README updates
• 24de30f Added updated Website class to parse webpages which is designed using JavaScript heavely at the end of week1 day1 notebook and tested it using openai, cnn, edwarddonner webpage
• 6ce9fd2 Fixed a bug identified by student Jon R - thank you!
• 01691fd Merge branch 'main' into SD_enhancements
• aadf31d Merge pull request #2 from scdufty/SD_enhancements
• 2244809 Organized community contributions and reset originals
• 2265ec5 Moved to community contributions folder
• e8b4205 Merge branch 'feature/parse-javascript-webpages'
• 6750db7 More comments, more business applications, and links to pkl files
• 871e91f Added community contributions to week 5 - separate ingestion and also Obsidian example
• a177dd0 README tweaks
• 7ff4fa8 Fixed a Windows problem - thank you John S for the fix!
• 7615ab4 Added a note about pausing HuggingFace endpoints
• ccac970 week2 task1
• 2c35264 Fixed an import, with many thanks to student Dr John S for pointing out
• b70a4c0 Readme updates and link to pkl files based on great community feedback
• aecf2cf Fixed the class definition - thank you Lucky P for pointing this out!
• 57397e4 More troubleshooting and setup tips, and some improvements to flagship Week 8 project
• a12b04a Added note about CloudFront protections - thank you Andy J!
• a52e092 Jupyer -> Jupyter
• 86cfdd8 Merge pull request #5 from mullaney/fix-mispelling
• 77a200c adding 3 way discussion including Gemini
• bb529ee More instructions and comments
• bdb8e8a Merge branch 'main' of github.com:ed-donner/llm_engineering
• 3bc9df0 Troubleshooting and wording improvements
• 684242f Added in student contribution
• a56af9e Merge branch 'w2t1'
• 3366e86 Added community contribution of a 3 way with Gemini
• a9cd1be Merge branch '3way'
• 15df5de Add files via upload
• a7cee4f More comments, notes and improvements
• 8a0feca Merge pull request #9 from billglennon/Week1_Challenge_Brochure_Translation
• 98000e5 Cleared the outputs
• b0c07f6 Simplified based on latest Gradio, and added PC fix for audio playback
• d454681 Updated the Windows PC encoding fix with thanks to CG and Jon R
• f5d661f Updates including more alternatives for PC audio generation
• fa0f64b add Google Gemini to the LLM Model Selections
• d75fe43 Further troubleshooting instructions, also a minor compatibility fix
• 8e2a115 removed Week2_Day2_with_GeminModel.ipynb
• 8353ddd Add Gemin Model using latest Gradio and Google API packages as of 11/3/2024
• a6d2961 Merge branch 'ed-donner:main' into week2day2-add-gemini-model
• 7306c7b Merge pull request #10 from billglennon/week2day2-add-gemini-model
• cbf475e Some comments and a fix to week 2 discovered by Bill G.
• 3102e48 add gemini to brochure, add tone to brochure, had to add safety_settings for google gemini to work with brochure
• 071c65e Merge pull request #11 from billglennon/week2day2-add-gemini-model
• c564337 Stream_Gemini
• 0262bbc Merge pull request #12 from makfava/main
• b4ffbe9 Updates to guides and troubleshooting
• be0a10d Fixed typo
• 14c06e3 Added resources link to README
• 64a17da Day 4 week2
• b8e9833 Refreshed notebooks, particularly with new Week 1
• c87a0b3 Latest Setup instructions and community contributions
• adebafa Minor README update
• 1d93431 Merge pull request #13 from makfava/main
• 51a8be6 Added Week2 end of week exercise
• f32b30a Merge branch 'main' of github.com:ed-donner/llm_engineering
• b28ead9 Added timeouts to give Modal time
• 0e62807 Updated due to breaking change in Gradio v5
• 3b66334 Updated explanations and tips
• d26d915 Added more resources
• 64a5a61 Added link to resources in README
• 7b4beff Added diagnostics reports to debug any issues
• 2a28637 Improved diagnostics
• 18b225f Minor diagnostics updates
• 686c2aa Added diagnostics info
• ef433cd Added more diagnostics
• 9fd8c4a Adding modifications for AWS, Azure and local ollama using OpenAI compatible API.
• 650d745 Fix NameError in code for streaming back results in markdown
• c52b1f9 Some tidy-up and added extra project
• 3ae3fdb renamed trading prototype
• c5fb39b Add files via upload
• 876081e Add files via upload
• b7409e9 Delete week1/solutions/day 5 personal tutor.ipynb
• b247bc4 Add files via upload
• 8065eec finish last two sections
• 0ed4f61 update unused variables.
• f733949 Merge pull request #17 from rogerscuall/aws-azure-ollama
• 0a58011 Refined troubleshooting and setup
• d61e764 Merge branch 'main' of github.com:ed-donner/llm_engineering
• 18db46f Adding checks for the ffprobe and ffplay as both are used too.
• 0387f4b Merge branch 'ed-donner:main' into main
• 9d13af7 Fixed so that model files are cached properly on modal
• 476257d **Add Week 1 Notebook to Community Contributions**
• 2ee70c7 Merge pull request #20 from ibarbo/ibarbo-day1-videotranscript-summary
• 80eb5d4 Merge pull request #16 from udayslathia16/main
• 68330e3 Merge pull request #19 from akempkens/main
• b7f3701 adding my contribution
• 60e8155 Merge pull request #24 from batikaniscan/day1-article-pdf-reader-feature
• c1be25d Typo. Fix from "Unknow" to "Unknown"
• 153ac2f Merge pull request #28 from rmeijsSdu/fix_typo_in_com_contrib_week2_day4
• ba871c2 Package updates, more Ollama, fixes
• 542ed43 Merge branch 'main' of github.com:ed-donner/llm_engineering
• 4b45d83 add discount tool
• bd7573d Merge pull request #33 from sandeepgangaram/week2-day2-multi-tool
• 5e1b302 Minor refinements
• bb26a4e Merge branch 'main' of github.com:ed-donner/llm_engineering
• 3584ebb Fixed a bug brilliantly spotted by Gabor M.
• ecb2a0a Updated README with Free API code snippet
• 7985c53 week 4 solution with audio input
• 4ab2b08 rename file
• b6e3494 add markdown
• e2e2970 Merge pull request #35 from sandeepgangaram/voice-to-text
• bc30ac7 My contribution
• 3e2d323 Working upsell example by PG - '3 for 2 offer'
• 21800df Added some comments
• 9dc2a16 Merge branch 'ed-donner:main' into week-2/day-3-contribution-upsell
File Changes
(1 file)
• A week2/community-contributions/day3.upsell.ipynb (355)
Patch Links:
• https://github.com/ed-donner/llm_engineering/pull/40.patch
• https://github.com/ed-donner/llm_engineering/pull/40.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ed,
This is my first pull request so it may be wrong.
Anyway, I created an upsell option for the clothes shop exercise, hope it's ok
BTW. Loving AI ...
Cheers Paul