Skip to content

Commit 283daf9

Browse files
authored
Use unencrypted password for deduplicated Credentials objects (duckduckgo#1959)
Task/Issue URL: https://app.asana.com/0/1199230911884351/1205352938100234/f Description: Credentials deduplication code looks for an existing credentials entity in the Secure Vault, then returns it to Sync code where its title is updated, and then the credentials entity is passed back to Secure Vault to be stored. The storing function expects unencrypted password (such as when passed from the UI) and does encryption before storing. The issue here was that we were passing an already encrypted password (just retrieved from Secure Vault) in which case the encryption function failed to encrypt the value, returning nil. This patch fixes the problem on the Sync Data Provider end (to feed an unencrypted password to Secure Vault for saving) and also adds an assertion failure to AutofillSecureVault when an encrypted password is passed to encryptPassword method.
1 parent 4aba081 commit 283daf9

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

DuckDuckGo.xcodeproj/project.pbxproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8874,7 +8874,7 @@
88748874
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
88758875
requirement = {
88768876
kind = exactVersion;
8877-
version = 75.2.0;
8877+
version = 75.2.1;
88788878
};
88798879
};
88808880
C14882EB27F211A000D59F0C /* XCRemoteSwiftPackageReference "SwiftSoup" */ = {

DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)