Commit 283daf9
authored
Use unencrypted password for deduplicated Credentials objects (duckduckgo#1959)
Task/Issue URL: https://app.asana.com/0/1199230911884351/1205352938100234/f
Description:
Credentials deduplication code looks for an existing credentials entity in the Secure Vault,
then returns it to Sync code where its title is updated, and then the credentials entity is passed
back to Secure Vault to be stored. The storing function expects unencrypted password
(such as when passed from the UI) and does encryption before storing.
The issue here was that we were passing an already encrypted password (just retrieved
from Secure Vault) in which case the encryption function failed to encrypt the value, returning nil.
This patch fixes the problem on the Sync Data Provider end (to feed an unencrypted password
to Secure Vault for saving) and also adds an assertion failure to AutofillSecureVault when an encrypted
password is passed to encryptPassword method.1 parent 4aba081 commit 283daf9
2 files changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8874 | 8874 | | |
8875 | 8875 | | |
8876 | 8876 | | |
8877 | | - | |
| 8877 | + | |
8878 | 8878 | | |
8879 | 8879 | | |
8880 | 8880 | | |
| |||
Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments