Conversation
raddevon
force-pushed
the
fastapi-import-aliases
branch
from
fe29b4b to
6e038ba
Compare
Contributor
Author
|
or it would be quick if I could get the linter check to pass. It passes locally but not here. 🤨 |
This was an attempt to fix a problem with the GitHub workflow. The worflow fails on GitHub although it passes locally. I had a linting problem when I initially pushed. I fixed this and force-pushed. I'm afraid it may be caching the pre-force-push code and running the workflow against that. Hoping these commits will invalidate that cache, if that is in fact the issue.
The old version I had installed locally was satisfied with the code, but the new version running on CI was not. This should allow the code to pass.
Contributor
Author
|
Finally figured this out. I was running the linters with older versions in local development while CI installs the latest each time. Black apparently changed how it handles some empty newlines. I believe this is ready for you, @1st1, when you have time. Guide PR is geldata/gel#4935 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be a quick one. I tested all the endpoints and methods interactively, and everything appears to work.