Skip to content

Add support for range types#377

Merged
colinhacks merged 12 commits intoproto-v1from
range
Jul 13, 2022
Merged

Add support for range types#377
colinhacks merged 12 commits intoproto-v1from
range

Conversation

@jaclarke
Copy link
Copy Markdown
Member

@jaclarke jaclarke commented Jul 1, 2022

Depends on geldata/gel#4016

Todo:

@jaclarke jaclarke force-pushed the range branch 4 times, most recently from 8ad82eb to 2ca72c3 Compare July 7, 2022 14:47
@jaclarke jaclarke changed the base branch from master to proto-v1 July 7, 2022 14:47
@jaclarke jaclarke force-pushed the range branch 2 times, most recently from 3a352cd to 5955556 Compare July 12, 2022 12:01
@colinhacks
Copy link
Copy Markdown
Contributor

Added some docs.

While playing around, I encountered this bug:

e.range(new LocalDate(1970, 1, 1), new LocalDate(2022, 1, 1));
/Users/colinmcd94/Documents/edgedb/js/qb/dbschema/edgeql-js/syntax/funcops.ts:77
  throw new Error(
        ^
Error: No function overload found for 'e.range()' with args: 1970-01-01, 2022-01-01
    at $resolveOverload (/Users/colinmcd94/Documents/edgedb/js/qb/dbschema/edgeql-js/syntax/funcops.ts:77:9)
    at Object.range (/Users/colinmcd94/Documents/edgedb/js/qb/dbschema/edgeql-js/syntax/range.ts:149:7)
    at run (/Users/colinmcd94/Documents/edgedb/js/qb/playground.ts:21:5)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

@colinhacks colinhacks marked this pull request as ready for review July 13, 2022 18:58
@colinhacks colinhacks merged commit 721d6ee into proto-v1 Jul 13, 2022
@colinhacks colinhacks deleted the range branch July 13, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants