Conversation
Add a `gel` alias that does `import *` from `edgedb`. Note that this will *not* provide any submodules. Doing `from gel import errors` won't work. But we also never documented anything internal, and it will all keep working with an `edgedb` import, so nothing will break. If we feel strongly about providing all the internal modules under the `gel` name also, we have options, but as far as I can tell they are all annoying in some way: - Generate a parallel tree of modules under `gel` that all do `import *` from an appropriate `edgedb` module. This is kind of ugly and also we need to regenerate when anything changes. - Something involving hooking the python import system. I think this would work but also I think involves modifying global python interpreter state when `gel` is imported, which is dodgy. I'd probably go with option 1 if we care, but not caring seems fine?
1st1
requested changes
Nov 16, 2024
Member
1st1
left a comment
There was a problem hiding this comment.
I think we should just rename and tell to people to start using "gel" if they want new stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
gelalias that doesimport *fromedgedb.Note that this will not provide any submodules.
Doing
from gel import errorswon't work.But we also never documented anything internal, and it will all keep
working with an
edgedbimport, so nothing will break.If we feel strongly about providing all the internal modules under the
gelname also, we have options, but as far as I can tell they areall annoying in some way:
gelthat all doimport *from an appropriate
edgedbmodule. This is kind of ugly and alsowe need to regenerate when anything changes.
would work but also I think involves modifying global python interpreter
state when
gelis imported, which is dodgy.I'd probably go with option 1 if we care, but not caring seems fine?