Conversation
fantix
force-pushed
the
proto-v3
branch
2 times, most recently
from
3a75bbc to
88831f2
Compare
msullivan
approved these changes
Nov 27, 2024
Member
msullivan
left a comment
msullivan
left a comment
There was a problem hiding this comment.
We should think about what refactor is needed to make adding things less annoying.
msullivan
added a commit
to geldata/gel
that referenced
this pull request
Nov 27, 2024
I incorrectly thought that geldata/gel-python#552 was going to require matching changes to testbase/connection.py, so I did an edgedb-python release so we could easily upgrade. It *didn't* require changes, and this was all a waste of time. Oh well.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dumpmessage