Closed
Conversation
anbuzin
reviewed
Feb 6, 2025
anbuzin
reviewed
Feb 6, 2025
added 2 commits
February 6, 2025 10:59
diksipav
changed the title
|
All commit authors signed the Contributor License Agreement. |
fantix
reviewed
Feb 20, 2025
gel/ai/vectorstore.py
Outdated
Comment on lines
+147
to
+149
| # Mark which fields were actually passed by the user (ignore 'id'). | ||
| # So if user calls Record(id=..., text=None), "text" will appear here. | ||
| object.__setattr__(self, "_explicitly_set_fields", set(kwargs.keys())) |
Member
There was a problem hiding this comment.
This can also be done by wrapping the constructor with a Python function.
fantix
reviewed
Feb 20, 2025
gel/ai/vectorstore.py
Outdated
| Record( | ||
| id=result.id, | ||
| text=result.text, | ||
| embedding=result.embedding and list(result.embedding), |
Author
There was a problem hiding this comment.
I think I had some type inconsistence, will see what happens after I update things
gel/ai/vectorstore.py
Outdated
| id=result.id, | ||
| text=result.text, | ||
| embedding=result.embedding and list(result.embedding), | ||
| metadata=(json.loads(result.metadata)), |
Member
There was a problem hiding this comment.
result.metadatacan beNone- redundant parentheses
fantix
reviewed
Feb 20, 2025
gel/ai/vectorstore.py
Outdated
| metadata := <json>$metadata, | ||
| } | ||
| select ( | ||
| insert {{record_type}} { |
Member
There was a problem hiding this comment.
Composing EdgeQL like this would need quoting, see edb.edgeql.quote.quote_ident() in the server code.
added 2 commits
March 3, 2025 15:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata filter should be further developed and tested. The castings are not correct in some cases, I don't have knowledge atm to anticipate all possible use cases for metadata filtering. I left comments where things should be further updated/developed.