Skip to content

Add timeout catches #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trgardos merged 1 commit into from
Oct 8, 2024
Merged

Add timeout catches #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion edubotics_core/dataloader/webpage_crawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ def url_exists(self, url: str) -> bool:
return response.status_code == 200
except requests.ConnectionError:
return False
except requests.exceptions.Timeout:
return False

async def get_links(self, session: ClientSession, website_link: str, base_url: str):
if not website_link.startswith(base_url):
Expand Down Expand Up @@ -104,7 +106,7 @@ def is_webpage(self, url: str) -> bool:
response = requests.head(url, allow_redirects=True, timeout=TIMEOUT)
content_type = response.headers.get("Content-Type", "").lower()
return "text/html" in content_type
except requests.RequestException:
except (requests.RequestException, ValueError, requests.exceptions.Timeout):
return False

def clean_url_list(self, urls):
Expand Down