Skip to content

feat: upgrade react to v18 #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huniafatima-99 merged 4 commits into from
Apr 4, 2025
Merged

feat: upgrade react to v18 #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d03b48f
feat: upgrade react to v18
huniafatima-99 Apr 3, 2025
d4632af
fix: added eslint disabling comment
huniafatima-99 Apr 3, 2025
17742fc
fix: replace REACTDOM.render with createRoot
huniafatima-99 Apr 4, 2025
72e00a8
chore: added strict mode to the app
huniafatima-99 Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 60 additions & 58 deletions example/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,73 +1,75 @@
import 'core-js/stable';
import 'regenerator-runtime/runtime';

import React from 'react';
import ReactDOM from 'react-dom';
import React, {StrictMode} from 'react';
import { AppContext, AppProvider } from '@edx/frontend-platform/react';
import { initialize, getConfig, subscribe, APP_READY } from '@edx/frontend-platform';
import Header, { StudioHeader } from '@edx/frontend-component-header';

import './index.scss';
import { createRoot } from "react-dom/client";

const rootNode = createRoot(document.getElementById('root'));
subscribe(APP_READY, () => {
ReactDOM.render(
<AppProvider>
{/* We can fake out authentication by including another provider here with the data we want */}
<AppContext.Provider value={{
authenticatedUser: null,
config: getConfig(),
}}>
<Header />
</AppContext.Provider>
<h5 className="mt-2 mb-5">Logged out state</h5>
rootNode.render(
<StrictMode>
<AppProvider>
{/* We can fake out authentication by including another provider here with the data we want */}
<AppContext.Provider value={{
authenticatedUser: null,
config: getConfig(),
}}>
<Header />
</AppContext.Provider>
<h5 className="mt-2 mb-5">Logged out state</h5>

{/* We can fake out authentication by including another provider here with the data we want */}
<AppContext.Provider value={{
authenticatedUser: {
userId: '123abc',
username: 'testuser',
name: 'Test User',
email: 'test@example.com',
roles: [],
administrator: false,
},
config: getConfig(),
}}>
<Header />
</AppContext.Provider>
<h5 className="mt-2 mb-5">Logged in state</h5>
<AppContext.Provider value={{
authenticatedUser: {
userId: '123abc',
username: 'testuser',
name: 'Test User',
email: 'test@example.com',
roles: [],
administrator: false,
},
config: getConfig(),
}}>
<StudioHeader
number="run123"
org="testX"
title="Course Name"
isHiddenMainMenu={false}
mainMenuDropdowns={[
{
id: 'content-dropdown',
buttonTitle: 'Content',
items: [{
href: '#',
title: 'Outline',
}],
{/* We can fake out authentication by including another provider here with the data we want */}
<AppContext.Provider value={{
authenticatedUser: {
userId: '123abc',
username: 'testuser',
name: 'Test User',
email: 'test@example.com',
roles: [],
administrator: false,
},
]}
outlineLink="#"
/>
</AppContext.Provider>
<h5 className="mt-2">Logged in state for Studio header</h5>
</AppProvider>,
document.getElementById('root'),
config: getConfig(),
}}>
<Header />
</AppContext.Provider>
<h5 className="mt-2 mb-5">Logged in state</h5>
<AppContext.Provider value={{
authenticatedUser: {
userId: '123abc',
username: 'testuser',
name: 'Test User',
email: 'test@example.com',
roles: [],
administrator: false,
},
config: getConfig(),
}}>
<StudioHeader
number="run123"
org="testX"
title="Course Name"
isHiddenMainMenu={false}
mainMenuDropdowns={[
{
id: 'content-dropdown',
buttonTitle: 'Content',
items: [{
href: '#',
title: 'Outline',
}],
},
]}
outlineLink="#"
/>
</AppContext.Provider>
<h5 className="mt-2">Logged in state for Studio header</h5>
</AppProvider>
</StrictMode>,
);
});

Expand Down
Loading