[MCKIN-7023] Ensures that default template tags are loaded for Django 1.11#49
Conversation
07895cc to
8ba7251
Compare
|
Thanks for catching and fixing this @pomegranited! 👍
|
|
@mduboseedx FYI, this is ready for review. It's blocking openedx/xblock-drag-and-drop-v2#154 and https://github.com/edx/edx-platform/pull/17670, so we'd really appreciate it if you could help us get it merged. |
|
@pomegranited This actually should not have opened an OSPR (something to figure out with our bot), but I'll check in with Brian to hopefully get this reviewed. @macdiesel Could this be looked at soon? It is blocking two other McKinsey PRs. |
|
Thank you for your help @mduboseedx ! |
|
Thank you for this PR! |
|
@macdiesel Thank you for getting on this so quickly! Pushed tag |
|
Although this pull request is already merged, I've created OSPR-5499 so that we can track it in Jira. There is nothing you have to do. No action is needed from your side. Thanks again for your contribution. |
Fixes bug related to the Django 1.11 upgrade and support for translations in XBlock templates added by #48.
Ensures that the standard Django templatetag libraries continue to work in XBlock templates (e.g., DnDv2 uses
l10n).JIRA tickets: MCKIN-7023, OSPR
Discussions: WL-230, YONK-879
Screenshots:
Before

Before this fix and since edx-platform was upgraded to Django 1.11, attempts to edit the DnDv2 XBlock in Studio resulted in this error:
After this change, DnDv2 XBlock can be edited as expected:

Sandbox URL: (provisioning)
Merge deadline: ASAP
Testing instructions:
Note that this works as expected.
Reviewers
CC @macdiesel