Use reflections8 rather than reflections#96
Merged
Conversation
egg82
reviewed
Feb 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue in reflections 0.9.12 which is well documented with the SubTypesScanner and TypeAnnotationsScanner. See ronmamo/reflections#273 for more information
While this didn't necessarily affect AntiVPN directly, when we put this on one of our servers with the current reflections library, it caused 20 of our plugins to fail to load (due to reflections breaking with Java8).
This build is tested, and shouldn't affect anything for any end users. It replaces the org.reflections.reflections library with org.oneandone.reflections8.reflections8 library, which is maintained and fixes this bug.