fix: remove --experimental-strip-types (#25)

and change to npm trusted publisher
node-modules/github-actions#14

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
* Updated the minimum required Node.js version in the installation
instructions.
* **Chores**
* Simplified linting configuration by extending an external base config
and removing local rule overrides.
* Updated Node.js engine requirement, development dependencies, and
removed the "alpha" publish tag.
  * Modified GitHub Actions workflow configuration for releases.
* **Style**
  * Refactored property access syntax in source files for consistency.
* **Tests**
  * Renamed imports in test files for clarity and consistency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: fengmk2

.github/workflows/release.yml

@@ -6,8 +6,7 @@ on:
 
 jobs:
   release:
-    name: Node.js
-    uses: eggjs/github-actions/.github/workflows/node-release.yml@master
+    name: NPM
+    uses: eggjs/github-actions/.github/workflows/npm-release.yml@master
     secrets:
-      NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
       GIT_TOKEN: ${{ secrets.GIT_TOKEN }}

.oxlintrc.json

@@ -4,152 +4,12 @@
     "node": true,
     "mocha": true
   },
-  "categories": {
-    "correctness": "error",
-    "perf": "error",
-    "nursery": "error",
-    "restriction": "error",
-    "style": "error",
-    "pedantic": "error",
-    "suspicious": "error"
-  },
-  "plugins": [
-    "import",
-    "typescript",
-    "unicorn",
-    "jsdoc",
-    "node",
-    "promise",
-    "oxc"
-  ],
-  "rules": {
-    // eslint
-    "constructor-super": "error",
-    "getter-return": "error",
-    "no-undef": "error",
-    "no-unreachable": "error",
-    "no-var": "error",
-    "no-eq-null": "error",
-    "no-await-in-loop": "allow",
-    "eqeqeq": ["error", "smart"],
-    "init-declarations": "allow",
-    "curly": "allow",
-    "no-ternary": "allow",
-    "max-params": ["error", 5],
-    "no-await-expression-member": "error",
-    "no-continue": "allow",
-    "guard-for-in": "allow",
-    "func-style": "allow",
-    "sort-imports": "allow",
-    "yoda": "allow",
-    "sort-keys": "allow",
-    "no-magic-numbers": "allow",
-    "no-duplicate-imports": "error",
-    "no-multi-assign": "error",
-    "func-names": "error",
-    "default-param-last": "error",
-    "prefer-object-spread": "error",
-    "no-undefined": "allow",
-    "no-plusplus": "allow",
-    // maybe warn
-    "no-console": "allow",
-    "no-extraneous-class": "allow",
-    "no-empty-function": "error",
-    "max-depth": ["error", 6],
-    "max-lines-per-function": "allow",
-    "no-lonely-if": "error",
-    "max-lines": "allow",
-    "require-await": "allow",
-    "max-nested-callbacks": ["error", 5],
-    "max-classes-per-file": "allow",
-    "radix": "allow",
-    "no-negated-condition": "error",
-    "no-else-return": "error",
-    "no-throw-literal": "error",
-    "id-length": "allow",
-    "arrow-body-style": "allow",
-
-    // import
-    "import/exports-last": "allow",
-    "import/max-dependencies": "allow",
-    "import/no-cycle": "error",
-    "import/no-anonymous-default-export": "allow",
-    "import/no-namespace": "error",
-    "import/named": "error",
-    "import/export": "error",
-    "import/no-default-export": "allow",
-    "import/unambiguous": "error",
-    "import/group-exports": "allow",
-    "import/extensions": "allow",
-    "import/consistent-type-specifier-style": "allow",
-    "import/prefer-default-export": "allow",
-
-    // promise
-    "promise/no-return-wrap": "error",
-    "promise/param-names": "error",
-    "promise/prefer-await-to-callbacks": "error",
-    "promise/prefer-await-to-then": "error",
-    "promise/prefer-catch": "error",
-    "promise/no-return-in-finally": "error",
-    "promise/avoid-new": "error",
-
-    // unicorn
-    "unicorn/error-message": "error",
-    "unicorn/no-null": "allow",
-    "unicorn/filename-case": "allow",
-    "unicorn/prefer-structured-clone": "error",
-    "unicorn/prefer-logical-operator-over-ternary": "error",
-    "unicorn/prefer-number-properties": "error",
-    "unicorn/prefer-array-some": "error",
-    "unicorn/prefer-string-slice": "error",
-    // "unicorn/no-null": "error",
-    "unicorn/throw-new-error": "error",
-    "unicorn/catch-error-name": "allow",
-    "unicorn/prefer-spread": "allow",
-    "unicorn/numeric-separators-style": "error",
-    "unicorn/prefer-string-raw": "error",
-    "unicorn/text-encoding-identifier-case": "error",
-    "unicorn/no-array-for-each": "error",
-    "unicorn/explicit-length-check": "error",
-    "unicorn/no-lonely-if": "error",
-    "unicorn/no-useless-undefined": "allow",
-    "unicorn/prefer-date-now": "error",
-    "unicorn/no-static-only-class": "allow",
-    "unicorn/no-typeof-undefined": "error",
-    "unicorn/prefer-negative-index": "error",
-    "unicorn/no-anonymous-default-export": "allow",
-
-    // oxc
-    "oxc/no-map-spread": "error",
-    "oxc/no-rest-spread-properties": "allow",
-    "oxc/no-optional-chaining": "allow",
-    "oxc/no-async-await": "allow",
-    "oxc/no-barrel-file": "allow",
-
-    // typescript
-    "typescript/explicit-function-return-type": "allow",
-    "typescript/consistent-type-imports": "error",
-    "typescript/consistent-type-definitions": "error",
-    "typescript/consistent-indexed-object-style": "allow",
-    "typescript/no-inferrable-types": "error",
-    "typescript/array-type": "error",
-    "typescript/no-non-null-assertion": "error",
-    "typescript/no-explicit-any": "error",
-    "typescript/no-import-type-side-effects": "error",
-    "typescript/no-dynamic-delete": "error",
-    "typescript/prefer-ts-expect-error": "error",
-    "typescript/ban-ts-comment": "error",
-    "typescript/prefer-enum-initializers": "error",
-    "typescript/explicit-module-boundary-types": "allow",
-
-    // jsdoc
-    "jsdoc/require-returns": "allow",
-    "jsdoc/require-param": "allow"
-  },
+  "rules": {},
   "ignorePatterns": [
     "index.d.ts",
     "test/fixtures/**",
     "__snapshots__",
     "example/cjs/helloworld.js"
-  ]
+  ],
+  "extends": ["./node_modules/@eggjs/oxlint-config/.oxlintrc.json"]
 }

Readme.md

@@ -19,7 +19,7 @@ Koa is not bundled with any middleware.
 
 ## Installation
 
-@eggjs/koa@3 requires **node v22.17.1** or higher for Node.js LTS support.
+@eggjs/koa@3 requires **node v22.18.0** or higher for Node.js LTS support.
 
 ```bash
 npm install @eggjs/koa

package.json

@@ -2,16 +2,15 @@
   "name": "@eggjs/koa",
   "version": "3.0.0",
   "engines": {
-    "node": ">= 22.17.1"
+    "node": ">= 22.18.0"
   },
   "publishConfig": {
-    "access": "public",
-    "tag": "alpha"
+    "access": "public"
   },
   "description": "Koa web app framework for https://eggjs.org",
   "scripts": {
     "pretest": "npm run lint -- --fix",
-    "test": "node --test --test-force-exit --test-update-snapshots --experimental-strip-types",
+    "test": "node --test --test-force-exit --test-update-snapshots",
     "preci": "npm run lint",
     "ci": "c8 -r html -r lcov -r text npm test",
     "postci": "npm run prepublishOnly",
@@ -64,6 +63,7 @@
     "vary": "^1.1.2"
   },
   "devDependencies": {
+    "@eggjs/oxlint-config": "^1.0.0",
     "@eggjs/tsconfig": "^3.0.0",
     "@types/accepts": "^1.3.7",
     "@types/content-type": "^1.1.8",
@@ -85,7 +85,7 @@
     "husky": "9",
     "lint-staged": "15",
     "mm": "^4.0.1",
-    "oxlint": "^1.9.0",
+    "oxlint": "^1.11.0",
     "prettier": "3",
     "supertest": "^3.1.0",
     "typescript": "^5.8.3"

src/context.ts

@@ -203,7 +203,7 @@ export class Context {
       return;
     }
 
-    const { res } = this;
+    const res = this.res;
 
     // first unset all headers
     for (const name of res.getHeaderNames()) {

src/response.ts

@@ -198,7 +198,7 @@ export class Response {
       return Number.parseInt(this.get('Content-Length')) || 0;
     }
 
-    const { body } = this;
+    const body = this.body;
     if (!body || body instanceof Stream) {
       return undefined;
     }

test/request/accept.test.ts

@@ -1,16 +1,16 @@
 import assert from 'node:assert/strict';
 import { describe, it } from 'node:test';
 
-import Accept from 'accepts';
+import accepts from 'accepts';
 
-import context, { request as Request } from '../test-helpers/context.ts';
+import context, { request as createRequest } from '../test-helpers/context.ts';
 
 describe('ctx.accept', () => {
   it('should return an Accept instance', () => {
     const ctx = context();
     ctx.req.headers.accept =
       'application/*;q=0.2, image/jpeg;q=0.8, text/html, text/plain';
-    assert.ok(ctx.accept instanceof Accept);
+    assert.ok(ctx.accept instanceof accepts);
   });
 });
 
@@ -20,10 +20,10 @@ describe('ctx.accept=', () => {
     ctx.req.headers.accept = 'text/plain';
     assert.deepStrictEqual(ctx.accepts(), ['text/plain']);
 
-    const request = Request();
+    const request = createRequest();
     request.req.headers.accept =
       'application/*;q=0.2, image/jpeg;q=0.8, text/html, text/plain';
-    ctx.accept = Accept(request.req);
+    ctx.accept = accepts(request.req);
     assert.deepStrictEqual(ctx.accepts(), [
       'text/html',
       'text/plain',

test/request/ip.test.ts

@@ -3,7 +3,7 @@ import { describe, it } from 'node:test';
 import Stream from 'node:stream';
 
 import Koa from '../../src/index.ts';
-import { request as Request } from '../test-helpers/context.ts';
+import { request as createRequest } from '../test-helpers/context.ts';
 
 describe('req.ip', () => {
   describe('with req.ips present', () => {
@@ -17,7 +17,7 @@ describe('req.ip', () => {
       req.headers['x-forwarded-for'] = '127.0.0.1';
       (req.socket as unknown as { remoteAddress: string }).remoteAddress =
         '127.0.0.2';
-      const request = Request(req, undefined, app);
+      const request = createRequest(req, undefined, app);
       assert.strictEqual(request.ip, '127.0.0.1');
     });
   });
@@ -27,7 +27,7 @@ describe('req.ip', () => {
       const req = { socket: new Stream.Duplex() };
       (req.socket as unknown as { remoteAddress: string }).remoteAddress =
         '127.0.0.2';
-      const request = Request(req);
+      const request = createRequest(req);
       assert.strictEqual(request.ip, '127.0.0.2');
     });
 
@@ -40,7 +40,7 @@ describe('req.ip', () => {
             // empty
           },
         });
-        assert.strictEqual(Request({ socket }).ip, '');
+        assert.strictEqual(createRequest({ socket }).ip, '');
       });
     });
   });
@@ -49,7 +49,7 @@ describe('req.ip', () => {
     const req = { socket: new Stream.Duplex() };
     (req.socket as unknown as { remoteAddress: string }).remoteAddress =
       '127.0.0.2';
-    const request = Request(req);
+    const request = createRequest(req);
     assert.strictEqual(request.ip, '127.0.0.2');
     (req.socket as unknown as { remoteAddress: string }).remoteAddress =
       '127.0.0.1';
@@ -60,7 +60,7 @@ describe('req.ip', () => {
     const req = { socket: new Stream.Duplex() };
     (req.socket as unknown as { remoteAddress: string }).remoteAddress =
       '127.0.0.2';
-    const request = Request(req);
+    const request = createRequest(req);
     assert.strictEqual(request.ip, '127.0.0.2');
     request.ip = '127.0.0.1';
     assert.strictEqual(request.ip, '127.0.0.1');