Skip to content

Convert to TypeScript #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hawx1993 wants to merge 5 commits into from
Closed

Convert to TypeScript #8

hawx1993 wants to merge 5 commits into from

Conversation

@hawx1993
Copy link

@hawx1993 hawx1993 commented Jun 14, 2019 •
edited by egoist
Loading

Convert to TypeScript

Closes #3

@hawx1993 hawx1993 closed this Jun 14, 2019
@hawx1993 hawx1993 reopened this Jun 14, 2019
egoist
egoist requested changes Jun 14, 2019
View reviewed changes
.eslintrc
"plugin:@typescript-eslint/eslint-recommended",
"plugin:@typescript-eslint/recommended"
]
}
Copy link
Owner

@egoist egoist Jun 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this project uses XO which is an eslint wrapper.

Copy link
Author

@hawx1993 hawx1993 Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Owner

@egoist egoist Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not what I mean, see

vue-compile/package.json

Line 51 in d5c0012

"xo": {

Copy link
Author

@hawx1993 hawx1993 Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, still can't work. I set:

"xo": {
    "extends": "xo-typescript",
    "extensions": [
      "ts"
    ],
    "rules": {
      "unicorn/filename-case": "off"
    }
  },

but report: Cannot find module 'eslint-plugin-@typescript-eslint'

@egoist
Copy link
Owner

egoist commented Jun 14, 2019

please update package.json accordingly. (we need to publish compiled code on npm)

@egoist egoist mentioned this pull request Jul 3, 2019
Merged
@egoist egoist closed this Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@egoist egoist egoist requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Convert to TypeScript

2 participants

@hawx1993 @egoist