Skip to content

Conversation

@saulshanabrook
Copy link
Member

Adds supports for the back off scheduler from experimental, and builds out mechanism in general to run custom schedulers.

Adds supports for the back off scheduler from experimental, and builds
out mechanism in general to run custom schedulers.
@saulshanabrook
Copy link
Member Author

@actions-user changelog

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the back_off scheduler from experimental, and builds out a general mechanism to run custom schedulers. The change enables users to create custom backoff schedulers with configurable parameters and use them in their egglog schedules.

  • Adds BackOff class and back_off() function for creating backoff schedulers
  • Updates run() function to accept an optional scheduler parameter
  • Implements automatic scheduler hoisting and scoping mechanisms

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
python/egglog/declarations.py Adds BackOffDecl, LetSchedulerDecl types and updates RunDecl to support schedulers
python/egglog/egraph.py Adds BackOff class, back_off() function, and updates run() to accept scheduler parameter
python/egglog/egraph_state.py Implements scheduler processing logic and conversion to egg commands
python/egglog/pretty.py Updates pretty printing to handle new scheduler declarations
python/tests/test_high_level.py Adds comprehensive test cases for scheduler functionality
python/tests/test_pretty.py Adds test cases for scheduler pretty printing
docs/reference/egglog-translation.md Documents the new scheduler feature with examples
python/egglog/examples/jointree.py Removes trailing empty lines

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 11, 2025

CodSpeed Instrumentation Performance Report

Merging #350 will not alter performance

Comparing schedule (a364098) with main (c7ba30d)

Summary

✅ 7 untouched benchmarks

@saulshanabrook saulshanabrook merged commit c8d24a3 into main Sep 11, 2025
5 checks passed
@saulshanabrook saulshanabrook deleted the schedule branch September 11, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants