Remove '%clang' requirement from several ACTS users #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the '%clang' compiler requirement from three packages (acts, eicrecon, and juggler) that previously needed clang due to older gcc versions being unable to compile them. With modern gcc versions now capable of compiling these packages, they can revert to using the global '%gcc' compiler requirement.
Key changes:
- Removed package-specific clang compiler overrides for acts, eicrecon, and juggler
- These packages will now use the global gcc compiler requirement instead
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wdconinc
force-pushed
the
wdconinc-patch-4
branch
2 times, most recently
from
a16780d to
d1d8965
Compare
This was referenced Nov 23, 2025
Removed '%clang' requirement from multiple packages in the YAML configuration.
wdconinc
force-pushed
the
wdconinc-patch-4
branch
from
d1d8965 to
41fa3e1
Compare
veprbl
approved these changes
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR removes the '%clang' requirement from multiple packages in the YAML configuration. The requirement was added some while back when the version of gcc was too old to compile ACTS (and other programs that include ACTS).
What kind of change does this PR introduce?