Skip to content

Conversation

l-ohlen-ericsson
Copy link
Contributor

Applicable Issues

Change to allow multiple FLOW_CONTEXT (#170)

Description of the Change

Changed the FLOW CONTEXT link type to allow multiple

Alternate Designs

Not considered

Benefits

Makes it possible to associate an Eiffel event with multiple flows

Possible Drawbacks

Non identified

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Lars Ohlén, lars.x.ohlen@ericsson.com

@d-stahl-ericsson
Copy link
Contributor

Version stepping is also required. I would argue that this constitutes a minor version change, e.g. 1.0.0 -> 1.1.0. It shouldn't be major, because a client expecting a 1.0.0 format and getting multiple FLOW_CONTEXT will still be able to parse it and get the same amount of information as before (but miss out on potential additional information).

One example of how to document version stepping can be found in the TERC event:

## Version History
| Version   | Introduced in                                          | Changes                                 |
| --------- | ------------------------------------------------------ | --------------------------------------- |
| 2.0.0     | Current version.                                       | Changed syntax of data.batches.recipes.constraints from an uncontrolled object to a list of key-value pairs to comply with design guidelines. |
| 1.0.0     | [edition-bordeaux](../../../tree/edition-bordeaux)     | Initial version.                        |

Following this change, that would then become

## Version History
| Version   | Introduced in                                          | Changes                                 |
| --------- | ------------------------------------------------------ | --------------------------------------- |
| 2.1.0     | Current version.                                       | Changed FLOW_CONTEXT link type to allow multiple links. |
| 2.0.0     |                                                        | Changed syntax of data.batches.recipes.constraints from an uncontrolled object to a list of key-value pairs to comply with design guidelines. |
| 1.0.0     | [edition-bordeaux](../../../tree/edition-bordeaux)     | Initial version.                        |

@d-stahl-ericsson
Copy link
Contributor

Superceded by #179

@magnusbaeck magnusbaeck added the protocol All protocol changes label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol All protocol changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants