Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed FLOW_CONTEXT link type to allow multiple links in same event #179

Merged
merged 2 commits into from Feb 20, 2018

Conversation

d-stahl-ericsson
Copy link
Contributor

Applicable Issues

Issue #170

Description of the Change

As per Issue #170, FLOW_CONTEXT has been changed in all events
to allow for multiple FLOW_CONTEXT links in the same event. This
is because situations where an entity may need to be associated
with multiple FlowContexts, e.g. a program and a track, are
common and there is no reason to restrict linkage to a single
FlowContext.

All events have been stepped one minor version. Schemas have
been supplied for the new versions. Note that the new schemas
are identical, however, as there is currently no validation
of links.

Where deemed appropriate, event examples have been stepped to
the new versions. One event example had two FLOW_CONTEXT links
added so that this new change is represented in at least one place.

Also fixed placement of the Version History heading in one event documentation, as it had been incorrectly placed in PR #176.

Alternate Designs

The alternative is to not allow multiple FLOW_CONTEXT per event, which was previously the case.

Benefits

Events can now reference multiple FlowContexts in parallel, e.g. a program and a track.

Possible Drawbacks

There is a room for contradictory information, i.e. referencing contradicting FlowContexts from the same event. There's no way to guard against this, or even determine what may be contradictory, from a protocol point of view, however, as this is purely a question of semantics.

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Daniel Ståhl, daniel.stahl@ericsson.com

As per Issue eiffel-community#170, FLOW_CONTEXT has been changed in all events
to allow for multiple FLOW_CONTEXT links in the same event. This
is because situations where an entity may need to be associated
with multiple FlowContexts, e.g. a program and a track, are
common and there is no reason to restrict linkage to a single
FlowContext.

All events have been stepped one minor version. Schemas have
been supplied for the new versions. Note that the new schemas
are identical, however, as there is currently no validation
of links.

Where deemed appropriate, event examples have been stepped to
the new versions. One event example had two FLOW_CONTEXT links
added so that this new change is represented in at least one place.
Copy link
Contributor

@l-ohlen-ericsson l-ohlen-ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@l-ohlen-ericsson l-ohlen-ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@erobged
Copy link

erobged commented Feb 20, 2018

+1

@erobged erobged closed this Feb 20, 2018
@erobged erobged reopened this Feb 20, 2018
@erobged
Copy link

erobged commented Feb 20, 2018

+1

@d-stahl-ericsson d-stahl-ericsson merged commit dd90ade into eiffel-community:master Feb 20, 2018
@d-stahl-ericsson d-stahl-ericsson deleted the issue170 branch September 13, 2018 10:31
@magnusbaeck magnusbaeck added the protocol All protocol changes label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol All protocol changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants