-
Notifications
You must be signed in to change notification settings - Fork 32
feat(GUI): allow setting passphrase when creating wallets #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2025-11-12.00-47-13c.mp4Opening this in feather prompts for a passphrase and writing in asd works |
src-gui/src/renderer/components/modal/seed-selection/SeedSelectionDialog.tsx
Outdated
Show resolved
Hide resolved
|
The Rust code looks good. We might also want to allow changing the password for an already existing wallet? Also not sure if we might want to move the password input to another page / a new dialog that is shown after the wallet is created? I think the UI I built for the wallet selection is already a bit cluttered and this argueably makes it a bit worse because even more stuff is shown on a single page. I like the wizard Feather wallet guides you through. |
|
Added password changer: 2025-11-12.20-22-35Q.mp4I disagree. The "select wallet" modal has everything configurable on one page that doesn't scroll. There's no clutter that I can see either: there's only the 2/3 inputs you need and that's it. |
|
bugbot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
|
It seems that tsc yields: |
Without saving, we can get the wallet into a state that causes libmonero to throw std::bad_alloc (in the GUI and in feather; opening it a second time in feather fixes it)
|
One day I'll not forget to git add a new file but that day is not today. Both fixed. |
|
Great work. I love the UI. I wanted to get this implemented for weeks, very happy we finally have this feature now. I'll be assuming #688 (comment) is still the address I should send the bounty to. Let me know if this is incorrect. I'll send the bounty in around an hour. |
|
Bounty of 0.25 XMR paid out to @nabijaczleweli in this transaction. |
|
I think it'd be crazy of me to change the address and not notify you. But while we're on the topic, as I GC my open-bounty tabs, I think you missed #710? |
That is probably true yes...but cannot be too cautious. I'll assume from now on that your address remains the same :) |
Closes: #689
Note
Enables setting a wallet password on create/restore and changing it later, wiring FFI, backend requests/commands, RPC, and GUI with a new password input.
Wallet::setPasswordbinding andFfiWallet::set_password, exposeWalletHandle::set_password.open_or_create_with_passwordandopen_or_create_from_seed_with_password; plumb optional password through open/recover paths.SeedChoicetoRandomSeed { password }andFromSeed { seed, password }; update wallet creation to pass password (or none if empty).SetMoneroWalletPasswordArgs/Responserequest; on success, persist viastore_in_current_file.set_monero_wallet_passwordcommand; addsetMoneroWalletPasswordinrenderer/rpc.ts.RandomSeedandFromSeed; button disabled until valid.NewPasswordInputcomponent for password + repeat with visibility toggle.SetPasswordModal.Written by Cursor Bugbot for commit e7f7070. This will update automatically on new commits. Configure here.