Conversation
Contributor
Author
|
You could argue that the sink should be responsible for measuring its own duration, and that this is working as intended as a "stream start" timing. |
We measure the action as done when the stream is returned, not when the stream itself is finished. This could be misleading.
44294f9 to
78221c9
Compare
This makes the timing metrics match expectations and lets us know of slowness between Eik and the sink.
leftieFriele
approved these changes
Aug 22, 2025
leftieFriele
left a comment
There was a problem hiding this comment.
👍 I think this change makes sense, as you would expect this metrics to measure the time it takes for an asset to be fetched. The time for it to start really isn't interesting, as that would mean we are measuring something internal in the client.
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 22, 2025
## [2.0.22](v2.0.21...v2.0.22) (2025-08-22) ### Bug Fixes * end timer on stream end or error ([#503](#503)) ([5cea253](5cea253))
|
🎉 This PR is included in version 2.0.22 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We measure the action as done when the stream is returned, not when the stream itself is finished. This could be misleading.
See the difference between
ENDandFINISH.