Skip to content

Conversation

@ej2
Copy link
Owner

@ej2 ej2 commented Apr 15, 2025

No description provided.

dimbleby and others added 24 commits February 12, 2025 21:04
The SKU field was not being properly returned when using Item.all() due to
the field not being explicitly requested in the query. This commit:

1. Adds test_sku_in_all() to tests/integration/test_item.py to verify SKU
   field retrieval
2. Removes trailing slashes from API URLs in get_single_object method
3. Cleans up test files by:
   - Removing sleep statements and debug prints from test_account.py
   - Using proper mocking in unit tests to avoid session dependency
   - Making test names and assertions more descriptive

The changes ensure that SKU values are correctly returned when querying
items through the all() method, while also improving the overall test
suite maintainability.

Testing:
- Added new integration test verifying SKU field retrieval
- All existing Item and Account tests pass
- Unit tests properly mock session dependencies
use minorversion 75 by default
Fix incompatibility issue with setuptools >= 78
Fix setuptools dashes into underscore
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 76.31579% with 18 lines in your changes missing coverage. Please review.

Project coverage is 93.26%. Comparing base (67141c2) to head (71693d0).

Files with missing lines Patch % Lines
quickbooks/mixins.py 41.66% 3 Missing and 4 partials ⚠️
quickbooks/client.py 81.48% 2 Missing and 3 partials ⚠️
quickbooks/objects/attachable.py 20.00% 4 Missing ⚠️
tests/unit/test_client.py 85.71% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   93.53%   93.26%   -0.28%     
==========================================
  Files         104      104              
  Lines        3991     4009      +18     
  Branches      108      118      +10     
==========================================
+ Hits         3733     3739       +6     
- Misses        219      224       +5     
- Partials       39       46       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ej2 ej2 merged commit 3b103d4 into master Apr 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants