Include https:// in PR link #148
Conversation
This allows terminals to make it highlighted and clicky. commit-id:ec630215
leoluk
force-pushed
the
pr/leoluk/develop/ec630215
branch
from
a5a39e9
to
e7a49b6
Compare
| @@ -167,7 +167,7 @@ func (pr *PullRequest) String(config *config.Config) string { | |||
|
|
|||
| prInfo := fmt.Sprintf("%3d", pr.Number) | |||
| if config.User.ShowPRLink { | |||
| prInfo = fmt.Sprintf("%s/%s/%s/pull/%d", | |||
| prInfo = fmt.Sprintf("https://%s/%s/%s/pull/%d", | |||
There was a problem hiding this comment.
my terminal actually highlights without the https, and I don't want to make the lines even longer.
instead of changing this here, will changing the githubHost in your spr.yml and adding a https:// prefix there work?
There was a problem hiding this comment.
I tried Alacritty, Kitty, urxvt, Gnome Terminal, Terminator and none of them had clicky links without the prefix. It seems your terminal would be the exception?
There was a problem hiding this comment.
I use iTerm.
But regardless, does updating your value of githubHost in the configuration file work for you?
There was a problem hiding this comment.
No, it breaks the logic that finds the access token from the config file.
There was a problem hiding this comment.
Either way I think we should pick a default that works in terminals that aren't iTerm - it's the only one I could find that highlights schema-less URLs
|
✓ Commit merged in pull request #156 |
Stack: