-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the "gh" CLI tool in addition to "hub" #156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably a matter of personal taste, but making it into a full sentence looks nicer in comments. commit-id:bdba0972
This allows terminals to make it highlighted and clicky. commit-id:ec630215
commit-id:36d19c89
Commit messages are not guaranteed to be valid Markdown. Wrapping them in a code area guarantees that the original formatting is preserved (say, ASCII art). This matches what GitHub itself does when rendering commits. This might be a matter of taste - maybe some people *do* write valid Markdown in their commits and want to keep the existing behavior - should we make it a config option? commit-id:33d44b17
commit-id:af2e94b5
spr PRs are almost never meant to be merged via the GitHub UI. Add a notice to every PR explaining not to merge manually. Exclude unstacked PRs. commit-id:2d753c44
Panics are usually reserved for programming errors (i.e. a bug in the code). This code path is frequently hit for user errors, like running "git amend" with an empty staging area. commit-id:e5019250
Checking the file into Git, don't want it to change on its own. commit-id:7aa48ec5
Turns out "hub" is deprecated and GitHub wants you to use this one instead: https://cli.github.com From playing with it, it seems strictly superior to hub since it does browser-based authentication and has a much wider array of supported operations. commit-id:48660ea6
This was referenced Dec 13, 2021
Closed
ejoffe
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack: