Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the "gh" CLI tool in addition to "hub" #156

Merged
merged 9 commits into from
Dec 18, 2021

Conversation

leoluk
Copy link
Collaborator

@leoluk leoluk commented Dec 13, 2021

Stack:

Turns out "hub" is deprecated and GitHub wants you
to use this one instead: https://cli.github.com

From playing with it, it seems strictly superior to hub
since it does browser-based authentication and has a much
wider array of supported operations.

commit-id:48660ea6

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

Probably a matter of personal taste, but making it into a
full sentence looks nicer in comments.

commit-id:bdba0972
This allows terminals to make it highlighted and clicky.

commit-id:ec630215
Commit messages are not guaranteed to be valid Markdown.
Wrapping them in a code area guarantees that the original
formatting is preserved (say, ASCII art).

This matches what GitHub itself does when rendering commits.

This might be a matter of taste - maybe some people *do*
write valid Markdown in their commits and want to keep the
existing behavior - should we make it a config option?

commit-id:33d44b17
spr PRs are almost never meant to be merged via the GitHub UI.
Add a notice to every PR explaining not to merge manually.

Exclude unstacked PRs.

commit-id:2d753c44
Panics are usually reserved for programming errors
(i.e. a bug in the code). This code path is frequently hit for
user errors, like running "git amend" with an empty staging area.

commit-id:e5019250
Checking the file into Git, don't want it to change on its own.

commit-id:7aa48ec5
Turns out "hub" is deprecated and GitHub wants you
to use this one instead: https://cli.github.com

From playing with it, it seems strictly superior to hub
since it does browser-based authentication and has a much
wider array of supported operations.

commit-id:48660ea6
@leoluk leoluk changed the base branch from pr/leoluk/develop/7aa48ec5 to master December 18, 2021 11:30
@leoluk leoluk merged commit 76a731f into master Dec 18, 2021
@leoluk leoluk deleted the pr/leoluk/develop/48660ea6 branch December 18, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants