Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update run count when user is not already a stargazer #154

Closed

Conversation

leoluk
Copy link
Collaborator

@leoluk leoluk commented Dec 9, 2021

@ejoffe
Copy link
Owner

ejoffe commented Dec 9, 2021

Although, I personally enjoy sometime looking in there and seeing how many times I ran spr:

showPRLink: true
logGitCommands: true
logGitHubCalls: true
statusBitsHeader: false
stargazer: true
runcount: 2245

@leoluk
Copy link
Collaborator Author

leoluk commented Dec 12, 2021

That's a lot of times! I'm only getting started :-) Already proving useful.

Checking the file into Git, don't want it to change on its own.

commit-id:7aa48ec5
@ejoffe
Copy link
Owner

ejoffe commented Dec 12, 2021

The main reason for the counter is for the stargaze prompt, so I'm ok with this change.
I'm not sure I understand why you are checking in the user config file?

@leoluk
Copy link
Collaborator Author

leoluk commented Dec 13, 2021

I have all config files in my home directory checked into Git for synchronization :)

@leoluk leoluk changed the base branch from pr/leoluk/develop/e5019250 to master December 13, 2021 13:05
@leoluk leoluk changed the base branch from master to pr/leoluk/develop/e5019250 December 13, 2021 13:05
@leoluk
Copy link
Collaborator Author

leoluk commented Dec 18, 2021

✓ Commit merged in pull request #156

@leoluk leoluk closed this Dec 18, 2021
@leoluk leoluk deleted the pr/leoluk/develop/7aa48ec5 branch December 18, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants