Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual merge notice #152

Closed

Conversation

leoluk
Copy link
Collaborator

@leoluk leoluk commented Dec 9, 2021

@ejoffe
Copy link
Owner

ejoffe commented Dec 9, 2021

What do you think of the following for the message (also a good place to insert a link to spr).

"Pull request is part of a pull request stack created by spr. Do not merge it manually using the UI, doing so may have unexpected results"

spr PRs are almost never meant to be merged via the GitHub UI.
Add a notice to every PR explaining not to merge manually.

Exclude unstacked PRs.

commit-id:2d753c44
@leoluk leoluk changed the base branch from pr/leoluk/develop/af2e94b5 to master December 13, 2021 13:05
@leoluk leoluk changed the base branch from master to pr/leoluk/develop/af2e94b5 December 13, 2021 13:05
@leoluk
Copy link
Collaborator Author

leoluk commented Dec 18, 2021

✓ Commit merged in pull request #156

@leoluk leoluk closed this Dec 18, 2021
@leoluk leoluk deleted the pr/leoluk/develop/2d753c44 branch December 18, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants