Fix issue with iamidentitymapping #4369
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We replaced occurrences of hardcoded `arn:aws` strings with calls of `addARNPartitionPrefix()`.
cPu1
reviewed
Oct 26, 2021
Contributor
cPu1
left a comment
cPu1
left a comment
There was a problem hiding this comment.
Thanks for the PR. Can you add a unit test for this change in pkg/cfn/builder/iam_test.go?
Author
|
I could try. However, after a first glance at the tests in |
|
+1 |
Contributor
|
This PR has been fixed by #4547. Thank you for your contribution, sorry, I didn't realise that this was also working on that part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should fix issues similar to #4329, where an ebs volume could not be created, due to missing aws-cn references.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯