Enable termination protection by default for eksctl CFN stacks #8586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhay-krishna
force-pushed
the
cfn-termination-protection
branch
from
7ebda22 to
5df6757
Compare
abhay-krishna
commented
Nov 13, 2025
abhay-krishna
commented
Nov 13, 2025
abhay-krishna
commented
Nov 13, 2025
Contributor
NicholasBlaskey
left a comment
NicholasBlaskey
left a comment
There was a problem hiding this comment.
looks good to me
See a couple build failures but after that and the tests pass looks good to me
abhay-krishna
force-pushed
the
cfn-termination-protection
branch
4 times, most recently
from
ad274dc to
41a2b8b
Compare
abhay-krishna
force-pushed
the
cfn-termination-protection
branch
from
41a2b8b to
792e601
Compare
abhay-krishna
force-pushed
the
cfn-termination-protection
branch
from
792e601 to
21a57b6
Compare
NicholasBlaskey
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable termination protection by default for the CloudFormation stacks that eksctl spins up during cluster creation.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯