This repository was archived by the owner on Jun 24, 2022. It is now read-only.
Simpler restart handling + issue-test for recreation of problems #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 20, 2017
Contributor
|
LGTM. Haven't looked, but hopefully the notify handler could be overridden with a proper rolling restart at some point. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the restart logic, relying on the restart handler only. We now notify the handler consistently and remove the additional checks.
This should close the following issues:
#305
#315
All tests pass locally.
I have also added issue-test.yml. This test will not be included in the new automated tests, but allows us to easily test playbooks for user issues. I'll add instructions once we have the automated test suite - users can in theory then issue a PR with a playbook in the test-issue.yml and immediately demonstrate the failure.
@barryib @jpcarey i believe this simplifies restarts significantly.