Make sure the error context is always set #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, most of the transaction context was set after the execution of a request. When capturing an exception, the transaction context is copied over at it's current state. That means when the user captures an exception, the the transaction context is not yet populated and therefore, the Error context is empty. This changes the initialization of the transaction context so that it is set before the request starts. That way, we can be sure that the Error context is always set
Member
Author
|
Hey @beniwohli, could you review the comments in the commit message and in |
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
============================================
+ Coverage 76.73% 77.08% +0.34%
- Complexity 947 953 +6
============================================
Files 99 99
Lines 3280 3282 +2
Branches 291 289 -2
============================================
+ Hits 2517 2530 +13
+ Misses 602 600 -2
+ Partials 161 152 -9
Continue to review full report at Codecov.
|
felixbarny
force-pushed
the
error-context-overhaul
branch
from
5085ff6 to
5a49986
Compare
beniwohli
approved these changes
Jul 2, 2018
beniwohli
left a comment
beniwohli
left a comment
There was a problem hiding this comment.
@felixbarny looks good! It's still not quite the same behavior as the Python (and AFAIK most other) agent, but close enough 👍
Member
Author
|
Thanks for having a look :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, most of the transaction context was set after the execution of a request.
When capturing an exception, the transaction context is copied over at its current state.
That means when the user captures an exception, the transaction context is not yet
populated and therefore, the Error context is empty.
This changes the initialization of the transaction context so that it is set
before the request starts.
That way, we can be sure that the Error context is always set